fix: cannot read properties of null (@alexmgullen)#7653
Closed
alexmgullen wants to merge 1 commit into
Closed
Conversation
Member
|
The fix is just to wait for vite/rolldown to fix the root cause: rolldown/rolldown#8712 - thank you though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
Upon finishing a test when you are in
Config.mode"time", "word" and "zen" the program will buffer indefinitely and the console will throw the following error:Reason
This happened because vite was optimizing this code:
into
without taking into account that
TestWords.currentQuotecould be null as per TypeScript:Changes
This commit simply sets
quoteLengthto be -1 by default, and andTestWords.currentQuote?.groupifConfig.modeis"quote".Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.ts