Skip to content

style: order contributors (@norwd)#7661

Closed
norwd wants to merge 1 commit into
monkeytypegame:masterfrom
norwd:style-order-contributors-norwd
Closed

style: order contributors (@norwd)#7661
norwd wants to merge 1 commit into
monkeytypegame:masterfrom
norwd:style-order-contributors-norwd

Conversation

@norwd
Copy link
Copy Markdown
Contributor

@norwd norwd commented Mar 16, 2026

Description

This is exactly equivalent to jq 'sort' ./frontend/static/contributors.json | sponge ./frontend/static/contributors.json

Checks

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

This is _exactly_ equivalent to `jq 'sort' ./frontend/static/contributors.json | sponge ./frontend/static/contributors.json`
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Mar 16, 2026
@Leonabcd123
Copy link
Copy Markdown
Contributor

Leonabcd123 commented Mar 16, 2026

What's wrong with the current ordering method (which is by commit count)?

@norwd
Copy link
Copy Markdown
Contributor Author

norwd commented Mar 16, 2026

What's wrong with the current ordering method (which is by commit count)?

My next PR was going to add some automation to keep this up to date, and I wanted the diff of that PR to be minimal. But now that I know it's by commit count I can just build that ordering into the automation. Thanks for letting me know that's what the order was @Leonabcd123!

@norwd norwd closed this Mar 16, 2026
@norwd norwd deleted the style-order-contributors-norwd branch March 16, 2026 20:56
@fehmer
Copy link
Copy Markdown
Member

fehmer commented Mar 16, 2026

hi @norwd, this fiile is generated.

@norwd
Copy link
Copy Markdown
Contributor Author

norwd commented Mar 16, 2026

@fehmer, it looks like the updates are applied manually (or at least at arbitrary intervals), would there be interest in having this updated automatically as part of each release? Or at least on some kind of schedule, six months between making a contribution and seeing it on the site seems like a long wait?

image

@Miodec
Copy link
Copy Markdown
Member

Miodec commented Mar 17, 2026

@fehmer, it looks like the updates are applied manually (or at least at arbitrary intervals), would there be interest in having this updated automatically as part of each release? Or at least on some kind of schedule, six months between making a contribution and seeing it on the site seems like a long wait?

image

I added the script as part of the release pipeline in 83c5ff1, thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants