Skip to content

chore: add stylelint linter for css/scss (@nadalaba)#7718

Open
nadalaba wants to merge 31 commits intomonkeytypegame:masterfrom
nadalaba:stylelint
Open

chore: add stylelint linter for css/scss (@nadalaba)#7718
nadalaba wants to merge 31 commits intomonkeytypegame:masterfrom
nadalaba:stylelint

Conversation

@nadalaba
Copy link
Copy Markdown
Contributor

@nadalaba nadalaba commented Mar 25, 2026

supersedes #7716

nadalaba added 26 commits March 25, 2026 18:33
@nadalaba
add stylelint for scss with all rules disabled
1cc8328
@nadalaba
re-add declaration-block-no-duplicate-properties rule to its default
653516d
@nadalaba
re-add block-no-empty rule
57b9439
@nadalaba
re-add font-family-no-missing-generic-family-keyword
d7a5c87
@nadalaba
re-add selector-type-no-unknown
0a4118d
@nadalaba
re-add selector-pseudo-element-colon-notation: double
f2d3b35
@nadalaba
re-add font-family-name-quotes: always-where-recommended
35f9f5f
@nadalaba
re-add function-url-quotes: always
e8f679f
@nadalaba
re-add property-no-vendor-prefix
03be1c9
@nadalaba
re-add value-no-vendor-prefix except for box and inline-box
2071438
@nadalaba
re-add no-invalid-position-at-import-rule
e49a0bc
@nadalaba
add stylelint for css with all rules disabled
41bde16
@nadalaba
re-add no-descending-specificity
dfbf1e7
@nadalaba
re-add no-duplicate-selectors
7f05e70
@nadalaba
re-add font-family-no-missing-generic-family-keyword
38200c8
@nadalaba
re-add declaration-block-no-shorthand-property-overrides
13d8a8e
@nadalaba
re-add declaration-property-value-no-unknown
fcd25fd
@nadalaba
re-add selector-type-no-unknown
cd86c8b
@nadalaba
re-add property-no-vendor-prefix
afa6f56
@nadalaba
re-add selector-pseudo-element-colon-notation: double
f8b0120
@nadalaba
re-add font-family-name-quotes: always-where-recommended
bdf4ac9
@nadalaba
re-add function-url-quotes: always
0cdb1e7
@nadalaba
re-add at-rule-no-unknown
5480020
@nadalaba
add stylelint to lint-staged
1cb4f14
@nadalaba
add stylelint to turbo, full-check and CI
84e23fe
@nadalaba
add stylelint vscode extension
5d41c8e
@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2026
@nadalaba nadalaba mentioned this pull request Mar 25, 2026
Closed
@nadalaba nadalaba marked this pull request as draft March 25, 2026 15:48
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2026
@nadalaba nadalaba marked this pull request as ready for review March 25, 2026 17:32
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Mar 25, 2026
@nadalaba
replace key type with kbd
fb5648c 
key tag is no longer used since 12e0035
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2026
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 26, 2026
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 7, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yaml → npm/vite@8.0.5

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vite@8.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Miodec
Miodec requested changes Apr 7, 2026
View reviewed changes
.github/workflows/monkey-ci.yml
should-build-fe: ${{ steps.export-changes.outputs.should-build-fe }}
should-build-pkg: ${{ steps.export-changes.outputs.should-build-pkg }}
assets-json: ${{ steps.export-changes.outputs.assets-json }}
assetsAndStyles: ${{ steps.export-changes.outputs.assetsAndStyles }}
Copy link
Copy Markdown
Member

@Miodec Miodec Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to assets-or-styles

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. backend Server stuff frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nadalaba @Miodec @monkeytypegeorge