Skip to content

refactor: move some test state to solid signals (@miodec)#8025

Merged
Miodec merged 3 commits into
masterfrom
move-test-state
May 29, 2026
Merged

refactor: move some test state to solid signals (@miodec)#8025
Miodec merged 3 commits into
masterfrom
move-test-state

Conversation

@Miodec
Copy link
Copy Markdown
Member

@Miodec Miodec commented May 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 07:58
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 29, 2026
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label May 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors frontend test runtime state by moving “invalid test” + “incomplete/restart tracking” + “last result” out of test-stats module globals into Solid signals in states/test, and updates test flow code to use the new signal accessors/setters.

Changes:

  • Add Solid signals + helper setters in frontend/src/ts/states/test.ts for invalid flag, last result, restart/incomplete tracking.
  • Update test-logic to read/write that state via signals (including reset points on restart/finish).
  • Update UI consumers (result.ts, pages/test.ts, test-stats.ts) to use the new state.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/src/ts/test/test-stats.ts Removes module-global lastResult/invalid/incomplete* state; getStats() now pulls last result from states/test.
frontend/src/ts/test/test-logic.ts Switches restart/incomplete/invalid/lastResult handling to states/test signals.
frontend/src/ts/test/result.ts Reads invalid-state via isTestInvalid() signal instead of TestStats.invalid.
frontend/src/ts/states/test.ts Introduces new signals for test invalid flag, last result, restart/incomplete tracking.
frontend/src/ts/pages/test.ts Resets incomplete/restart signal state on beforeShow instead of TestStats.resetIncomplete().

Comment thread frontend/src/ts/states/test.ts
@github-actions
Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels May 29, 2026
@github-actions github-actions Bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 29, 2026
@Miodec Miodec merged commit 033c7cf into master May 29, 2026
17 checks passed
@Miodec Miodec deleted the move-test-state branch May 29, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants