Skip to content

fix(font): Add Sindhi-specific CSS for font clarity (@Shamsuddin45)#8202

Open
Shamsuddin45 wants to merge 2 commits into
monkeytypegame:masterfrom
Shamsuddin45:patch-4
Open

fix(font): Add Sindhi-specific CSS for font clarity (@Shamsuddin45)#8202
Shamsuddin45 wants to merge 2 commits into
monkeytypegame:masterfrom
Shamsuddin45:patch-4

Conversation

@Shamsuddin45

Copy link
Copy Markdown
Contributor

Add language-specific CSS for Sindhi language font clarity.

Description

Checks

  • Adding quotes?
    • Make sure to follow the quotes documentation
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

Add language-specific CSS for Sindhi language font clarity.
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jul 6, 2026
@Shamsuddin45 Shamsuddin45 changed the title Add Sindhi-specific CSS for font clarity fix(font): Add Sindhi-specific CSS for font clarity (@Shamsuddin45) Jul 6, 2026
@fehmer

fehmer commented Jul 6, 2026

Copy link
Copy Markdown
Member

hi, why is this needed. what makes sindhi different to other languages with joiningScript?

@Shamsuddin45

Copy link
Copy Markdown
Contributor Author

hi, why is this needed. what makes sindhi different to other languages with joiningScript?

Thanks for pointing that out.

I noticed this specifically while testing the Sindhi language. With the default font and letter spacing, some Sindhi words were rendered incorrectly because certain joining characters appeared disconnected. Applying letter-spacing: normal together with a font that properly supports Sindhi (e.g. Noto Sans Arabic/Lateef) fixed the rendering.

I haven't yet verified whether the same issue affects all other joiningScript languages, so I scoped the change to Sindhi to avoid changing typography for languages I hadn't tested.

@fehmer

fehmer commented Jul 7, 2026

Copy link
Copy Markdown
Member

the selected fonts are not provided by the website, so this fix would only work, if the user has them installed locally.

The current fallback fonts in case the font doesn't contain the characters to display are "Roboto Mono" and "Vazirharf".

The fix doesnt seem to work:
image

@Shamsuddin45

Copy link
Copy Markdown
Contributor Author

the selected fonts are not provided by the website, so this fix would only work, if the user has them installed locally.

The current fallback fonts in case the font doesn't contain the characters to display are "Roboto Mono" and "Vazirharf".

The fix doesnt seem to work: image

Is there a way that if a user selects the Sindhi language, the font is automatically set to MB Lateefi (best for sindhi) for the words only?
Please guide me

@Shamsuddin45

Copy link
Copy Markdown
Contributor Author

the selected fonts are not provided by the website, so this fix would only work, if the user has them installed locally.
The current fallback fonts in case the font doesn't contain the characters to display are "Roboto Mono" and "Vazirharf".
The fix doesnt seem to work: image

Is there a way that if a user selects the Sindhi language, the font is automatically set to MB Lateefi (best for sindhi) for the words only?
Please guide me

image

@fehmer

fehmer commented Jul 8, 2026

Copy link
Copy Markdown
Member

hi @Shamsuddin45 ,

could you provide an example custom text in sindhi and two screenshots, one with the default font and one with the MB lateefi font.

And could you find a font that is open source that does the same?
Would this one work? https://software.sil.org/lateef/

@fehmer

fehmer commented Jul 8, 2026

Copy link
Copy Markdown
Member

#8208

@Shamsuddin45

Shamsuddin45 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

hi @Shamsuddin45 ,

could you provide an example custom text in sindhi and two screenshots, one with the default font and one with the MB lateefi font.

And could you find a font that is open source that does the same?

Of course here is it !

Screenshot 1 is "MB Lateefi" & Screenshot 2 is "Roboto Mono"

image image

@fehmer

fehmer commented Jul 8, 2026

Copy link
Copy Markdown
Member

is this the same text? can you provide it as text as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants