refactor chat list loading and folder synchronization

- remove redundant `chatFolders` update collection in `ChatsListRepositoryImpl` as it is handled elsewhere
- eliminate unnecessary initial `selectFolder` call in `DefaultChatListComponent` initialization
- simplify `isRequestActive` and folder ID validation checks with single-line returns
- remove manual client-side filtering of `includedChatIds` in `ChatListContent`, relying on the data layer for folder content
- refine shimmer logic in `ChatListContent` to prevent flickering by holding initial content during the first folder transition while loading

Author: gdlbo

data/src/main/java/org/monogram/data/repository/ChatsListRepositoryImpl.kt

@@ -307,13 +307,6 @@ class ChatsListRepositoryImpl(
                     }
                 }
         }
-
-        scope.launch {
-            updates.chatFolders.collect { update ->
-                folderManager.handleChatFoldersUpdate(update)
-                triggerUpdate()
-            }
-        }
     }
 
     private suspend fun rebuildAndEmit() {
@@ -638,9 +631,7 @@ class ChatsListRepositoryImpl(
         setLoadingState(folderId, requestId, true)
 
         scope.launch(dispatchers.io) {
-            if (!isRequestActive(folderId, requestId)) {
-                return@launch
-            }
+            if (!isRequestActive(folderId, requestId)) return@launch
 
             val currentCount = _chatListFlow.value.size
             if (currentCount < currentLimit) {

presentation/src/main/java/org/monogram/presentation/features/chats/list/ChatListContent.kt

@@ -121,7 +121,7 @@ import org.monogram.presentation.R
 import org.monogram.presentation.core.ui.Avatar
 import org.monogram.presentation.core.ui.ConfirmationSheet
 import org.monogram.presentation.core.util.LocalTabletInterfaceEnabled
-import org.monogram.presentation.features.chats.list.ChatListComponent
+import org.monogram.presentation.features.chats.conversation.ui.message.getEmojiFontFamily
 import org.monogram.presentation.features.chats.list.components.AccountMenu
 import org.monogram.presentation.features.chats.list.components.ArchiveHeaderCard
 import org.monogram.presentation.features.chats.list.components.ChatListItem
@@ -132,7 +132,6 @@ import org.monogram.presentation.features.chats.list.components.FolderTabs
 import org.monogram.presentation.features.chats.list.components.MessageSearchItem
 import org.monogram.presentation.features.chats.list.components.PermissionRequestSheet
 import org.monogram.presentation.features.chats.list.components.SelectionTopBar
-import org.monogram.presentation.features.chats.conversation.ui.message.getEmojiFontFamily
 import org.monogram.presentation.features.instantview.InstantViewer
 import org.monogram.presentation.features.stickers.ui.menu.EmojisGrid
 import org.monogram.presentation.features.webapp.MiniAppViewer
@@ -1104,16 +1103,15 @@ fun ChatListContent(component: ChatListComponent) {
                         return@HorizontalPager
                     }
                     val rawFolderChats = foldersState.chatsByFolder[folderId].orEmpty()
-                    val folderChats = if (folderId > 0 && folder.includedChatIds.isNotEmpty()) {
-                        val includedChatIds = folder.includedChatIds.toHashSet()
-                        rawFolderChats.filter { chat -> chat.id in includedChatIds }
-                    } else {
-                        rawFolderChats
-                    }
+                    val folderChats = rawFolderChats
                     val isFolderLoading = foldersState.isLoadingByFolder[folderId] ?: false
                     val hasFolderLoadState = foldersState.isLoadingByFolder.containsKey(folderId)
-                    val showFolderShimmer = folderChats.isEmpty() && (isFolderLoading || !hasFolderLoadState)
                     val shouldAnimateFirstFolderTransition = firstFolderTransitionCompleted[folderId] != true
+                    val shouldHoldInitialFolderContent = folderId > 0 &&
+                            shouldAnimateFirstFolderTransition &&
+                            isFolderLoading
+                    val showFolderShimmer = shouldHoldInitialFolderContent ||
+                            (folderChats.isEmpty() && (isFolderLoading || !hasFolderLoadState))
 
                     val scrollState = rememberManagedChatListState(
                         stateKey = "folder:$folderId",

presentation/src/main/java/org/monogram/presentation/features/chats/list/DefaultChatListComponent.kt

@@ -35,9 +35,6 @@ import org.monogram.presentation.BuildConfig
 import org.monogram.presentation.core.util.AppPreferences
 import org.monogram.presentation.core.util.coRunCatching
 import org.monogram.presentation.core.util.componentScope
-import org.monogram.presentation.features.chats.list.ChatListComponent
-import org.monogram.presentation.features.chats.list.ChatListStore
-import org.monogram.presentation.features.chats.list.ChatListStoreFactory
 import org.monogram.presentation.root.AppComponentContext
 
 class DefaultChatListComponent(
@@ -367,10 +364,6 @@ class DefaultChatListComponent(
                 }
             }
             .launchIn(scope)
-
-        scope.launch(Dispatchers.IO) {
-            chatListRepository.selectFolder(_state.value.selectedFolderId)
-        }
     }
 
     override fun retryConnection() = store.accept(ChatListStore.Intent.RetryConnection)
@@ -405,9 +398,7 @@ class DefaultChatListComponent(
         if (_state.value.isLoadingByFolder[targetFolderId] == true) return
 
         scope.launch(Dispatchers.IO) {
-            if (folderId != null && folderId != _state.value.selectedFolderId) {
-                return@launch
-            }
+            if (folderId != null && folderId != _state.value.selectedFolderId) return@launch
             chatListRepository.loadNextChunk(20)
         }
     }