TODO/fix(v16): implement MeterValues in TriggerMessageHandler#72
Open
vindexTOS wants to merge 3 commits into
Open
TODO/fix(v16): implement MeterValues in TriggerMessageHandler#72vindexTOS wants to merge 3 commits into
vindexTOS wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’m testing my app against the 1.6 emulator and needed TriggerMessage for MeterValues to work. Turned out that part wasn’t implemented (only a TODO in the handler), so I added it as best I could.
Changes: the handler now calls a new sendMeterValues on ChargePointManager, which picks the right connector(s) from the request, reuses the existing meter-value generation and config, and sends a MeterValues request per connector (including transaction when there’s an active one).
I’m targeting main since that’s your default branch. Happy to adjust if you’d rather use another base or change anything in the implementation.
Please review when you have time — and thanks for this project.