Refactor e2e parse result handling to use try/catch#69
Open
bobzhang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
try?+match Ok/Errpatterns with directtry ... catchto simplify control flow and make parse error handling explicit in e2e test helpers.Description
run_single_valid_testandrun_single_invalid_testine2e/runner.mbtto wrap@toml.parse(...)withtry ... catchwhile preserving existing mismatch and parse-error messages.e2e/e2e_test.mbtto usetry ... catcharound each parse and keep pass/fail counters and failure reporting unchanged.Testing
moon fmt, butmoonis not available in the environment (moon: command not found), so no automated formatting ormoon-based tests were executed.Codex Task