Consider bringing back extension-controlled fullscreen support

[tomciaaa]

Following changes in #524 , I'm facing an issue where in fullscreen mode the top window bar appears when I scroll to the top of the screen (similarly, the taskbar appears if I scroll to the bottom). This used to not happen with extension-managed fullscreen mode (at least I'm fairly certain as it gets in the way of my point-to-click games where scrolling to the side to pan the map is a fairly common thing to do).

I can't seem to find any settings to turn this behaviour off.

(I think this only happens in cases where the mouse locking is off as per #518 as turning on mouse-capture effectively fixes the mouse position in-place as far as Chrome OS is concerned)

[utopiafallen]

I think making a toggle to opt-in to extension controlled fullscreen would be doable but possibly confusing from a usage standpoint since there would be multiple ways to get to fullscreen. Out of curiousity, how are you exiting streaming sessions with your Chromebook right now?

[tomciaaa]

So I don't think we need a toggle as such. I think removing the old behaviour where the extension started in fullscreen is fine as it's broken anyway. I think simply re-adding the keyboard shortcut to fullscreen would be what I'm after. Also I think it's fairly reasonable from a usage perspective as it won't get in the way unless you know about the shortcut (and I'd claim similar to how web video players have fullscreen shortcuts).

As for exiting the session, I use the Ctrl+Alt+Shift+Q shortcut, but most often I'd just quit the game.

[utopiafallen]

Wait, what was the keyboard shortcut that got removed? Also, the only way to get back the fullscreen behavior you want where the top window bar and the bottom chrome launcher don't show up when the cursor is near those areas is to manually transition to fullscreen using the old app controlled way that was removed by my PR. So, from a usability point of view, putting the legacy behavior behind an advanced shortcut seems ok, but it means the app needs to handle fullscreen changes happening from different sources if the same shortcut is supposed to always toggle fullscreen correctly. A simpler (in code) solution would be to have dedicated shortcuts to enter and exit fullscreen so no state tracking is needed. Would that work for you?

…

On Mon, Jan 2, 2023, 10:48 PM tomciaaa ***@***.***> wrote: So I don't think we need a toggle as such. I think removing the old behaviour where the extension started in fullscreen is fine as it's broken anyway. I think simply re-adding the keyboard shortcut to fullscreen would be what I'm after. Also I think it's fairly reasonable from a usage perspective as it won't get in the way unless you know about the shortcut (and I'd claim similar to how web video players have fullscreen shortcuts). As for exiting the session, I use the Ctrl+Alt+Shift+Q shortcut, but most often I'd just quit the game. — Reply to this email directly, view it on GitHub <#528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOT7JNIENZ7IICYY2XF7RTWQPDTLANCNFSM6AAAAAATOTG5SY> . You are receiving this because you commented.Message ID: ***@***.***>