fixed crash in web browser + unity + webgl#146
Open
liange wants to merge 1 commit into
Open
Conversation
Member
|
Thanks, will merge asap (currently on holyday 🌴 😎 |
|
@xanathar This issue is still present in the Unity asset store build on 6/6/2018 and this pull request fixes it. It really should be merged |
LimpingNinja
self-requested a review
January 10, 2020 10:11
LimpingNinja
requested changes
Jan 16, 2020
LimpingNinja
left a comment
LimpingNinja
left a comment
Contributor
There was a problem hiding this comment.
Cleanly submit the changes against the newest version to resolve conflicts and don't reformat the entire file like this, we can review and merge the line-item changes once resubmitted.
|
@LimpingNinja Could we take over this PR? It seems the PR author is inactive now. This issue can be still observed in Unity WebGL backend. |
Contributor
Definitely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnityAssetsScriptLoader.LoadResourcesWithReflection:
Array array = (Array)loadAll.Invoke(null, new object[] { assetsPath, textAssetType });
this code will crash in unity5.4 + webgl + web browser