No NullReferenceException when passing null to Table.Set#179
Open
bplu4t2f wants to merge 2 commits into
Open
Conversation
…try instead of causing a NullReferenceException in Table.PerformTableSet
LimpingNinja
self-requested a review
January 16, 2020 00:29
LimpingNinja
left a comment
LimpingNinja
left a comment
Contributor
There was a problem hiding this comment.
It's a little late, not certain if we should be checkin IsNil() here as well to be clear on the assumed intent. I may be wrong though, I probably should sleep. We do need an appropriate test case added to this PR as well if you can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing null as value parameter in any of the Table.Set overloads causes a NullReferenceException in Table.PerformTableSet. I propose either a proper ArgumentNullException, or giving null a reasonable meaning. Considering the similarity to setting the value to nil (instead of null) it might be reasonable to assume that the intent of the user in this case is to remove the value from the table.