test: improve code coverage

Author: adamdecaf

internal/achhelp/id_test.go

@@ -0,0 +1,29 @@
+package achhelp_test
+
+import (
+	"path/filepath"
+	"testing"
+
+	"github.com/moov-io/ach"
+	"github.com/moov-io/rail-msg-sql/internal/achhelp"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestPopulatedIDs(t *testing.T) {
+	file, err := ach.ReadFile(filepath.Join("..", "search", "testdata", "ach", "ppd-debit.ach"))
+	require.NoError(t, err)
+
+	file = achhelp.PopulateIDs(file)
+	require.NotNil(t, file)
+
+	// File ID
+	require.Equal(t, "5256dc55cab0a28d9ee8d2ccddec55d97477372573caff4de56ce85bee0f0a7b", file.ID)
+
+	// Batch ID
+	require.Equal(t, "7cf510873dc46d322fd93777487472d1efed4d4e3bdbccb0e8068ff108eddd7b", file.Batches[0].ID())
+
+	// Entry ID
+	entries := file.Batches[0].GetEntries()
+	require.Equal(t, "7d47b497f775a8957ae3a9a58e94bc5fa1acdacfa17b644019c3f715671c3f4e", entries[0].ID)
+}

internal/storage/repository_test.go

@@ -0,0 +1,46 @@
+package storage_test
+
+import (
+	"context"
+	"path/filepath"
+	"testing"
+	"time"
+
+	"github.com/moov-io/ach"
+	achwebviewer "github.com/moov-io/ach-web-viewer/pkg/service"
+	"github.com/moov-io/rail-msg-sql/internal/storage"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestRepository(t *testing.T) {
+	repo, err := storage.NewRepository(storage.Config{
+		ACH: achwebviewer.Sources{
+			{
+				Filesystem: &achwebviewer.FilesystemConfig{
+					Paths: []string{
+						filepath.Join("testdata", "ach"),
+					},
+				},
+			},
+		},
+		ACHValidateOpts: &ach.ValidateOpts{
+			AllowMissingFileHeader:  true,
+			AllowMissingFileControl: true,
+		},
+	})
+	require.NoError(t, err)
+
+	// Change dir so filelist package lets us read the dir
+	t.Chdir(filepath.Join("..", "search"))
+
+	ctx := context.Background()
+	params := storage.FilterParams{
+		StartDate: time.Date(2018, time.September, 1, 0, 0, 0, 0, time.UTC),
+		EndDate:   time.Date(2100, time.January, 1, 0, 0, 0, 0, time.UTC),
+	}
+
+	files, err := repo.ListAchFiles(ctx, params)
+	require.NoError(t, err)
+	require.Greater(t, len(files), 5)
+}

makefile

@@ -35,7 +35,7 @@ ifeq ($(OS),Windows_NT)
 else
 	@wget -O lint-project.sh https://raw.githubusercontent.com/moov-io/infra/master/go/lint-project.sh
 	@chmod +x ./lint-project.sh
-	COVER_THRESHOLD=40.0 ./lint-project.sh
+	COVER_THRESHOLD=50.0 ./lint-project.sh
 endif
 
 .PHONY: teardown