Feature/stan (#958)

* remove old CategorySeeder, stan errors category package

* draft phpstan

* expiry phpstam

* Fix styling

* firewall phpstan

* localization phpstan

* media phpstan

* Fix styling

* login-link phpstan

* packages phpstan

* prompts phpstan

* record phpstan

* security phpstan

* Fix styling

* slug phpstan

* tag phpstan

* user phpstan

* Fix styling

* user-device phpstan

* Fix styling

* remove non-ignorable

Author: AzGasim

packages/category/database/seeders/CategorySeeder.php

@@ -145,19 +145,19 @@ public function mediaThroughUsables()
     public function getDisplayTitleAttribute(): string
     {
         $defaultLocalization = Localization::where('is_default', true)->first();
-        $mainLocale = $defaultLocalization?->locale_variant ?? config('app.locale', 'en');
+        $mainLocale = $defaultLocalization !== null
+            ? ($defaultLocalization->locale_variant ?? config('app.locale', 'en'))
+            : config('app.locale', 'en');
         $currentLocale = request()->query('lang') ?? $mainLocale;
 
-        if (method_exists($this, 'translate')) {
-            $translation = $this->translate($currentLocale);
-            if ($translation && ! empty($translation->title)) {
-                return $translation->title;
-            }
+        $translation = $this->translate($currentLocale);
+        if ($translation && ! empty($translation->title)) {
+            return $translation->title;
+        }
 
-            $mainTranslation = $this->translate($mainLocale);
-            if ($mainTranslation && ! empty($mainTranslation->title)) {
-                return $mainTranslation->title.' ('.$mainLocale.')';
-            }
+        $mainTranslation = $this->translate($mainLocale);
+        if ($mainTranslation && ! empty($mainTranslation->title)) {
+            return $mainTranslation->title.' ('.$mainLocale.')';
         }
 
         return $this->attributes['title'] ?? ('ID: '.$this->id);

packages/category/src/Models/Category.php

@@ -5,7 +5,7 @@
 use Moox\Category\Resources\CategoryResource;
 use Moox\Draft\Models\Draft;
 use Moox\Media\Resources\MediaResource;
-use Moox\News\Moox\Entities\News\News\NewsResource;
+use Moox\News\Resources\NewsResource;
 use Moox\Tag\Models\Tag;
 use Moox\Tag\Resources\TagResource;
 use Moox\User\Models\User;

packages/draft/config/draft.php

@@ -8,7 +8,7 @@
 use Filament\Tables\View\TablesRenderHook;
 use Illuminate\Support\Facades\Blade;
 use Moox\Core\MooxServiceProvider;
-use Moox\Draft\Moox\Entities\Drafts\Draft\Pages\ListDrafts;
+use Moox\Draft\Resources\DraftResource\Pages\ListDrafts;
 use Spatie\LaravelPackageTools\Package;
 
 class DraftServiceProvider extends MooxServiceProvider

packages/draft/src/DraftServiceProvider.php

@@ -3,6 +3,7 @@
 namespace Moox\Draft\Models;
 
 use Carbon\Carbon;
+use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Moox\Core\Entities\Items\Draft\BaseDraftModel;
 use Moox\Core\Traits\Taxonomy\HasModelTaxonomy;
@@ -27,9 +28,8 @@
  * @property-read string $description
  * @property-read string $content
  * @property-read string $status
- * @property-read int $author_id
- * @property-read string $author_type
- * @property-read User|null $author
+ * @property-read int|null $author_id
+ * @property-read string|null $author_type
 
  * @property-read Collection<int, Media> $media
  */

packages/draft/src/Models/Draft.php

@@ -2,7 +2,6 @@
 
 namespace Moox\Expiry\Jobs;
 
-use Carbon\Carbon;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
@@ -33,31 +32,32 @@ public function handle(): void
                 $query->whereNull('escalated_to')
                     ->whereNotNull('escalated_at');
             })
+            ->with('notifyUser')
             ->get();
 
         if ($escalatedExpiries->isEmpty()) {
             return;
         }
 
-        $escalatedEntries = $escalatedExpiries->filter(fn ($entry): bool => isset($entry->escalated_at));
+        $escalatedEntries = $escalatedExpiries->filter(fn (Expiry $entry): bool => $entry->escalated_at !== null);
 
         $data = [
-            'escalatedEntries' => $escalatedEntries->map(function (Expiry $entry) {
+            'escalatedEntries' => $escalatedEntries->map(function (Expiry $entry): array {
                 return [
                     'title' => $entry->title,
-                    'expired_at' => Carbon::parse($entry->expired_at)->diffForHumans(),
-                    'processing_deadline' => Carbon::parse($entry->processing_deadline)->diffForHumans(),
-                    'escalated_at' => Carbon::parse($entry->escalated_at)->format('d.m.Y'),
-                    'notified_to' => config('expiry.user_model')::where('ID', $entry->notified_to)->first()?->display_name,
-                    'user_email' => config('expiry.user_model')::where('ID', $entry->notified_to)->first()?->email,
+                    'expired_at' => $entry->expired_at?->diffForHumans(),
+                    'processing_deadline' => $entry->processing_deadline?->diffForHumans(),
+                    'escalated_at' => $entry->escalated_at?->format('d.m.Y'),
+                    'notified_to' => $entry->notifyUser?->display_name,
+                    'user_email' => $entry->notifyUser?->email,
                     'category' => $entry->category,
                 ];
             }),
         ];
 
-        $responsibleEmail = config('expiry.user_model')::where('ID', $escalatedExpiries->first()->notified_to)->first()?->email;
+        $responsibleEmail = $escalatedExpiries->first()->notifyUser?->email;
 
-        Mail::to($responsibleEmail)
+        Mail::to($responsibleEmail ?: $adminEmail)
             ->cc($adminEmail)
             ->send(new EscalatedExpiriesMail($data, $panelPath));
 

packages/expiry/src/Jobs/SendEscalatedExpiriesJob.php

@@ -2,15 +2,39 @@
 
 namespace Moox\Expiry\Models;
 
+use Carbon\Carbon;
 use Exception;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Support\Collection;
 use Moox\Core\Traits\SoftDelete\SingleSoftDeleteInModel;
+use Moox\Press\Models\WpUser;
 use Moox\Press\QueryBuilder\UserQueryBuilder;
 use Override;
 
+/**
+ * @property int $id
+ * @property string|null $title
+ * @property string|null $slug
+ * @property int|null $item_id
+ * @property int|null $meta_id
+ * @property string|null $link
+ * @property string|null $expiry_job
+ * @property string|null $category
+ * @property string|null $status
+ * @property Carbon|null $expired_at
+ * @property Carbon|null $processing_deadline
+ * @property string|null $cycle
+ * @property Carbon|null $notified_at
+ * @property int|null $notified_to
+ * @property Carbon|null $escalated_at
+ * @property int|null $escalated_to
+ * @property int|null $handled_by
+ * @property Carbon|null $done_at
+ * @property-read WpUser|null $notifyUser
+ * @property-read WpUser|null $escalateUser
+ */
 class Expiry extends Model
 {
     use HasFactory;

packages/expiry/src/Models/Expiry.php

@@ -183,7 +183,7 @@ private function isIpAllowedForRequest(string $ip, Request $request, array $conf
             return true;
         }
 
-        $allowedRoutes = is_array($entry->allowed_routes) ? $entry->allowed_routes : [];
+        $allowedRoutes = (array) $entry->allowed_routes;
         if ($allowedRoutes === []) {
             return false;
         }

packages/firewall/src/Http/Middleware/EnsureFirewallAccess.php

@@ -91,13 +91,13 @@ private static function getCommonRoutePatternOptions(): array
         $prefixes = array_values(array_unique($prefixes));
         sort($prefixes);
 
-        return array_filter([
+        return [
             '/' => '/',
             'admin/*' => 'admin/*',
             'api/*' => 'api/*',
             'connect/*' => 'connect/*',
             ...array_combine($prefixes, $prefixes) ?: [],
-        ]);
+        ];
     }
 
     /**
@@ -133,7 +133,7 @@ private static function searchRoutePatternOptions(string $search): array
      */
     private static function iterRouteUris(): \Generator
     {
-        foreach (Route::getRoutes() as $route) {
+        foreach (Route::getRoutes()->getRoutes() as $route) {
             $middleware = $route->gatherMiddleware();
 
             // Filter out API-only routes, keep everything else (Filament routes don't always

packages/firewall/src/Resources/FirewallWhitelistEntryResource.php

@@ -143,7 +143,8 @@ public static function form(Schema $schema): Schema
                                     ->default(true)
                                     ->disabled(function ($get, $livewire) {
                                         // Disabled when this localization is set as default
-                                        $isDefault = $get('is_default') ?? $livewire->record?->is_default ?? false;
+                                        $record = $livewire->record;
+                                        $isDefault = $get('is_default') ?? ($record !== null ? $record->is_default : false);
 
                                         return $isDefault;
                                     }),
@@ -155,8 +156,9 @@ public static function form(Schema $schema): Schema
                                     ->default(false)
                                     ->disabled(function ($get, $livewire) {
                                         // Disabled when English is selected as default
-                                        $localeVariant = $get('locale_variant') ?? $livewire->record?->locale_variant ?? '';
-                                        $isDefault = $get('is_default') ?? $livewire->record?->is_default ?? false;
+                                        $record = $livewire->record;
+                                        $localeVariant = $get('locale_variant') ?? ($record !== null ? $record->locale_variant : '');
+                                        $isDefault = $get('is_default') ?? ($record !== null ? $record->is_default : false);
 
                                         // If it is an English localization AND already set as default
                                         if (strpos($localeVariant, 'en_') === 0 && $isDefault) {