Skip to content

moq-lite-05: remove Publisher Cache hint#34

Merged
kixelated merged 2 commits into
mainfrom
claude/amazing-pasteur-5a7ae3
Jun 21, 2026
Merged

moq-lite-05: remove Publisher Cache hint#34
kixelated merged 2 commits into
mainfrom
claude/amazing-pasteur-5a7ae3

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

What

Removes the Publisher Cache hint from moq-lite-05.

  • Drops the Publisher Cache (i) field and its definition block from TRACK_INFO.
  • Trims the Track delivery-preference bullet to just Max Latency (subscriber).
  • Reworks the Expiration and SUBSCRIBE cross-references so retention for FETCH / future subscriptions is described as best-effort, left to the publisher.
  • Reverts the brief Subscriber Stale rename back to Subscriber Max Latency (its v04 name), and fixes a historical moq-lite-03 changelog entry that had been incorrectly updated to the new name.
  • Cleans up a stale max_latency reference and drops the now-incorrect "set by either peer" (only the subscriber sets it).
  • Updates the moq-lite-05 changelog: the rename entry becomes a removal entry, and Publisher Cache is dropped from the new TRACK_INFO field list.

Why

The Publisher Cache retention guarantee felt out of place in the wire format. Retention is now an implementation concern rather than a negotiated property.

Notes for reviewers

Subscriber Max Latency is retained — it's the subscriber-side delivery/expiration preference, a distinct concept that remains well integrated into the Expiration section. Draft builds clean via make draft-lcurley-moq-lite.txt.

🤖 Generated with Claude Code

The Publisher Cache property (a publisher-side retention guarantee in
TRACK_INFO) felt out of place, so remove it from the wire format. Retention
for FETCH and future subscriptions is now best-effort and left to the
publisher. Subscriber Max Latency (formerly briefly renamed Subscriber Stale)
keeps the v04 name and remains the subscriber's delivery-time expiration
preference.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kixelated, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 38 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 877817be-5bec-484a-b0bc-7516183173e9

📥 Commits

Reviewing files that changed from the base of the PR and between 1a4e123 and fd76791.

📒 Files selected for processing (1)
  • draft-lcurley-moq-lite.md

Walkthrough

The spec renames the per-subscription latency field from Subscriber Stale to Subscriber Max Latency in the Track preference list, the SUBSCRIBE wire format, the SUBSCRIBE_UPDATE wire format, and their field descriptions. The Expiration section is rewritten to frame this field as a delivery-time preference only: the publisher resets Group Streams whose age exceeds the value and may retain groups on a best-effort basis for FETCH or future subscriptions. The Publisher Cache field is removed from the TRACK_INFO wire format and its descriptive text is deleted. Changelog entries are updated to reflect all renames and removals.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: removing the Publisher Cache hint from moq-lite-05, which aligns with the primary focus of the changeset.
Description check ✅ Passed The description comprehensively explains what is being removed, what is being updated, the rationale, and includes notes for reviewers, all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/amazing-pasteur-5a7ae3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@draft-lcurley-moq-lite.md`:
- Line 1070: The changelog entry in the moq-lite-05 section incorrectly
identifies the removed field name as "Publisher Max Latency" when it should be
"Publisher Cache (i)". Correct the field name in the changelog bullet point at
line 1070 from "Publisher Max Latency" to "Publisher Cache" to match the actual
field that was removed from the TRACK_INFO message structure and align with the
descriptive text that follows about the publisher's retention guarantee.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b218164b-1600-44de-9045-1e0a06deae53

📥 Commits

Reviewing files that changed from the base of the PR and between 0a66e5c and 1a4e123.

📒 Files selected for processing (1)
  • draft-lcurley-moq-lite.md

Comment thread draft-lcurley-moq-lite.md
…r-5a7ae3

# Conflicts:
#	draft-lcurley-moq-lite.md
@kixelated kixelated merged commit 5782aaf into main Jun 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant