moq-lite-05: remove Publisher Cache hint#34
Conversation
The Publisher Cache property (a publisher-side retention guarantee in TRACK_INFO) felt out of place, so remove it from the wire format. Retention for FETCH and future subscriptions is now best-effort and left to the publisher. Subscriber Max Latency (formerly briefly renamed Subscriber Stale) keeps the v04 name and remains the subscriber's delivery-time expiration preference. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 12 minutes and 38 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe spec renames the per-subscription latency field from Subscriber Stale to Subscriber Max Latency in the Track preference list, the SUBSCRIBE wire format, the SUBSCRIBE_UPDATE wire format, and their field descriptions. The Expiration section is rewritten to frame this field as a delivery-time preference only: the publisher resets Group Streams whose age exceeds the value and may retain groups on a best-effort basis for FETCH or future subscriptions. The Publisher Cache field is removed from the TRACK_INFO wire format and its descriptive text is deleted. Changelog entries are updated to reflect all renames and removals. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@draft-lcurley-moq-lite.md`:
- Line 1070: The changelog entry in the moq-lite-05 section incorrectly
identifies the removed field name as "Publisher Max Latency" when it should be
"Publisher Cache (i)". Correct the field name in the changelog bullet point at
line 1070 from "Publisher Max Latency" to "Publisher Cache" to match the actual
field that was removed from the TRACK_INFO message structure and align with the
descriptive text that follows about the publisher's retention guarantee.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b218164b-1600-44de-9045-1e0a06deae53
📒 Files selected for processing (1)
draft-lcurley-moq-lite.md
…r-5a7ae3 # Conflicts: # draft-lcurley-moq-lite.md
What
Removes the
Publisher Cachehint from moq-lite-05.Publisher Cache (i)field and its definition block from TRACK_INFO.Max Latency(subscriber).Subscriber Stalerename back toSubscriber Max Latency(its v04 name), and fixes a historicalmoq-lite-03changelog entry that had been incorrectly updated to the new name.max_latencyreference and drops the now-incorrect "set by either peer" (only the subscriber sets it).Publisher Cacheis dropped from the new TRACK_INFO field list.Why
The
Publisher Cacheretention guarantee felt out of place in the wire format. Retention is now an implementation concern rather than a negotiated property.Notes for reviewers
Subscriber Max Latencyis retained — it's the subscriber-side delivery/expiration preference, a distinct concept that remains well integrated into the Expiration section. Draft builds clean viamake draft-lcurley-moq-lite.txt.🤖 Generated with Claude Code