moq-lite-05: add broadcast Epoch and rename ANNOUNCE messages#35
Conversation
Add an Epoch field to ANNOUNCE_BROADCAST (a varint, before the Hop ID list): an opaque, application-defined value ordering instances of a broadcast, where larger means newer. It is origin-assigned and forwarded unchanged by relays. Subscribers resolve duplicate advertisements of the same broadcast by largest Epoch first (path length only breaks ties), so a reconnecting publisher can take over immediately instead of waiting for the stale session to time out. Rename ANNOUNCE_INTEREST to ANNOUNCE_REQUEST (the subscriber's request to receive announcements) and ANNOUNCE to ANNOUNCE_BROADCAST (the publisher's per-broadcast advertisement); ANNOUNCE_OK is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 18 minutes and 10 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
New
Epochfield onANNOUNCE_BROADCAST(a varint, placed before the Hop ID list):activeadvertisements of the same broadcast by largestEpochwins; total path length now only breaks ties between equal epochs. Forended, the epoch identifies which instance ended, so a subscriber already on a newer instance can ignore a staleended.0means unassigned (resolved by path length alone).Renamed the Announce messages:
ANNOUNCE_INTEREST→ANNOUNCE_REQUEST(the subscriber's request to receive announcements)ANNOUNCE→ANNOUNCE_BROADCAST(the publisher's per-broadcast advertisement)ANNOUNCE_OKunchanged.Why
Without an explicit ordering signal, a subscriber facing a reconnecting publisher has to wait for the old session to time out before it can safely route to the new one. The
Epochlets it switch immediately. The rename makes the trioANNOUNCE_REQUEST→ANNOUNCE_OK→ANNOUNCE_BROADCASTself-describing (the request asks for announcements; the broadcast advertisement says what is announced).Reviewer notes
moq-lite-05. Draft builds clean (make draft-lcurley-moq-lite.txt).draft-lcurley-moq-hang.mdstill references the oldANNOUNCEmessage name (lines 71, 77–85). Those cross-references are now stale against the rename — left for a follow-up unless reviewers prefer they be updated in this PR.🤖 Generated with Claude Code