[codex] upgrade TypeScript 7 RC#1938
Conversation
28bf4dc to
24dc0e9
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The TypeScript version is hard-coded separately in many package.json files; consider centralizing this (e.g., via a shared workspace config or tooling) to reduce duplication and make future upgrades easier.
- The extended Omit list in CreateOptions (style, className, classList, id, dataset, attributes) is now fairly specific; consider adding a brief comment near the type to explain why these keys are excluded so future changes to the create() implementation don’t inadvertently diverge from the typing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The TypeScript version is hard-coded separately in many package.json files; consider centralizing this (e.g., via a shared workspace config or tooling) to reduce duplication and make future upgrades easier.
- The extended Omit list in CreateOptions (style, className, classList, id, dataset, attributes) is now fairly specific; consider adding a brief comment near the type to explain why these keys are excluded so future changes to the create() implementation don’t inadvertently diverge from the typing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (17)
WalkthroughThe ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
7.0.1-rc.@moq/signalsDOM create option typing so TypeScript 7 accepts the customattributesmap.Impact
TypeScript 7 is currently published as the npm
rctag rather thanlatest. This PR pins the exact RC version so installs do not float back to the stable TypeScript 6 release.Validation
bunx tsc --versionbun run --filter='*' checkNote: after rebasing the PR branch onto current
main,just checkwas also attempted. The JS and Rust portions passed, then the repo-widejust --fmt --checkstep failed on unrelated justfile formatting diffs outside this PR.(Written by Claude)