Skip to content

[codex] upgrade TypeScript 7 RC#1938

Merged
kixelated merged 1 commit into
mainfrom
codex/upgrade-typescript-7-rc
Jun 28, 2026
Merged

[codex] upgrade TypeScript 7 RC#1938
kixelated merged 1 commit into
mainfrom
codex/upgrade-typescript-7-rc

Conversation

@kixelated

@kixelated kixelated commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Pin JS workspace TypeScript dev dependencies to 7.0.1-rc.
  • Refresh the root and standalone infra Bun lockfiles for the TypeScript 7 RC package layout.
  • Fix @moq/signals DOM create option typing so TypeScript 7 accepts the custom attributes map.

Impact

TypeScript 7 is currently published as the npm rc tag rather than latest. This PR pins the exact RC version so installs do not float back to the stable TypeScript 6 release.

Validation

  • bunx tsc --version
  • bun run --filter='*' check

Note: after rebasing the PR branch onto current main, just check was also attempted. The JS and Rust portions passed, then the repo-wide just --fmt --check step failed on unrelated justfile formatting diffs outside this PR.

(Written by Claude)

@kixelated kixelated force-pushed the codex/upgrade-typescript-7-rc branch from 28bf4dc to 24dc0e9 Compare June 28, 2026 20:21
@kixelated kixelated marked this pull request as ready for review June 28, 2026 20:23
@kixelated kixelated merged commit 404ec17 into main Jun 28, 2026
2 checks passed
@kixelated kixelated deleted the codex/upgrade-typescript-7-rc branch June 28, 2026 20:23

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The TypeScript version is hard-coded separately in many package.json files; consider centralizing this (e.g., via a shared workspace config or tooling) to reduce duplication and make future upgrades easier.
  • The extended Omit list in CreateOptions (style, className, classList, id, dataset, attributes) is now fairly specific; consider adding a brief comment near the type to explain why these keys are excluded so future changes to the create() implementation don’t inadvertently diverge from the typing.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The TypeScript version is hard-coded separately in many package.json files; consider centralizing this (e.g., via a shared workspace config or tooling) to reduce duplication and make future upgrades easier.
- The extended Omit list in CreateOptions (style, className, classList, id, dataset, attributes) is now fairly specific; consider adding a brief comment near the type to explain why these keys are excluded so future changes to the create() implementation don’t inadvertently diverge from the typing.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82d99319-2dea-4cf0-9ffa-55c0b80be72c

📥 Commits

Reviewing files that changed from the base of the PR and between 060726e and 24dc0e9.

⛔ Files ignored due to path filters (3)
  • bun.lock is excluded by !**/*.lock
  • infra/apt/bun.lock is excluded by !**/*.lock
  • infra/rpm/bun.lock is excluded by !**/*.lock
📒 Files selected for processing (17)
  • demo/boy/package.json
  • demo/web/package.json
  • infra/apt/package.json
  • infra/rpm/package.json
  • js/clock/package.json
  • js/flate/package.json
  • js/hang/package.json
  • js/json/package.json
  • js/loc/package.json
  • js/moq-boy/package.json
  • js/msf/package.json
  • js/net/package.json
  • js/publish/package.json
  • js/signals/package.json
  • js/signals/src/dom.ts
  • js/token/package.json
  • js/watch/package.json

Walkthrough

The typescript devDependency is updated from ^6.0.3 (or ^6) to the pinned pre-release 7.0.1-rc across all 16 package.json files in the repository (demo/, infra/, and js/ packages). Separately, CreateOptions<T> in js/signals/src/dom.ts expands its Omit list to also exclude className, classList, id, and attributes from the generic passthrough type, in addition to the previously excluded style and dataset.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/upgrade-typescript-7-rc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant