fix: add dark background color for .q-drawer in dark mode#249
Open
AmoghParmar wants to merge 1 commit into
Open
fix: add dark background color for .q-drawer in dark mode#249AmoghParmar wants to merge 1 commit into
AmoghParmar wants to merge 1 commit into
Conversation
AmoghParmar
force-pushed
the
fix/dark-theme-drawer-overlap
branch
from
efebf68 to
7e50282
Compare
Fixes the drawer overlap issue in dark mode by adding an explicit background-color override for .q-drawer when the dark theme is active. Closes moqui#248
AmoghParmar
force-pushed
the
fix/dark-theme-drawer-overlap
branch
from
7e50282 to
a04d2be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the dark mode drawer overlap issue reported in #248.
When the dark theme (
body--dark) is active, the.q-drawercomponent lacks a background color override, causing it to appear transparent and overlap/blend with other content on horizontal scroll.Fix
Added a dark background color override for the drawer in
WebrootVue.qvt.css, right alongside the existing.body--dark .q-menurule:File Changed
base-component/webroot/screen/webroot/css/WebrootVue.qvt.cssRelated Issue
Closes #248