Skip to content

Migrate build and tests to vite and jest#720

Merged
bingenito merged 20 commits into
morganstanley:mainfrom
bingenito:vite
Apr 30, 2025
Merged

Migrate build and tests to vite and jest#720
bingenito merged 20 commits into
morganstanley:mainfrom
bingenito:vite

Conversation

@bingenito
Copy link
Copy Markdown
Member

No description provided.

@bingenito bingenito requested a review from a team as a code owner March 13, 2025 12:02
@bingenito bingenito marked this pull request as draft March 13, 2025 12:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.98%. Comparing base (d3abaf9) to head (4fc924a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/desktopjs-electron/src/electron.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #720       +/-   ##
===========================================
- Coverage   93.87%   73.98%   -19.89%     
===========================================
  Files          16       16               
  Lines        1486     1507       +21     
  Branches      249      301       +52     
===========================================
- Hits         1395     1115      -280     
- Misses         90      392      +302     
+ Partials        1        0        -1     
Flag Coverage Δ
unittests 73.98% <0.00%> (-19.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/desktopjs/src/desktop.ts 100.00% <ø> (ø)
packages/desktopjs/src/events.ts 100.00% <ø> (ø)
packages/desktopjs/src/window.ts 78.94% <ø> (-9.55%) ⬇️
packages/desktopjs-electron/src/electron.ts 26.54% <0.00%> (-70.29%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bingenito bingenito marked this pull request as ready for review March 24, 2025 16:18
lilla28
lilla28 previously approved these changes Apr 10, 2025
@bingenito bingenito marked this pull request as draft April 14, 2025 14:21
kruplm
kruplm previously approved these changes Apr 14, 2025
@bingenito bingenito dismissed stale reviews from kruplm and lilla28 via 8817539 April 14, 2025 18:18
@bingenito bingenito changed the title Migrate build and tests from gulp/jasmine/jest to vite and vitest Migrate build and tests to vite and jest Apr 14, 2025
@kruplm kruplm marked this pull request as ready for review April 22, 2025 12:32
@kruplm
Copy link
Copy Markdown
Contributor

kruplm commented Apr 29, 2025

@bingenito this readme should be updated to say "openfin-cli" instead of "openfin" when launching the examples.

Other than that LGTM - tested in browsers and OpenFin

@bingenito
Copy link
Copy Markdown
Member Author

bingenito commented Apr 29, 2025

@bingenito this readme should be updated to say "openfin-cli" instead of "openfin" when launching the examples.

Other than that LGTM - tested in browsers and OpenFin

@kruplm That package is a bit misleading as the command doesn't match the package name. So if you install locally or globally you are installing openfin-cli but the command is just openfin. I'll update the readme in separate PR to just use npx instead of requiring install.

@bingenito bingenito merged commit 148a02b into morganstanley:main Apr 30, 2025
4 of 5 checks passed
@bingenito bingenito deleted the vite branch April 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants