Add command and args#68
Merged
Merged
Conversation
Owner
|
did you check how you can do it through sidecar or init container? - add some packages into - it's bad practice |
Author
|
@morgoved I didn’t quite understand why you merged these changes. I agree that this isn’t best practice. |
Owner
|
@Assylbek2002 i just merged your latest PR and this also merged too, anyway - for chart, support command/args - will be ok. can be alot of case for use this normaly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to install the requests library in the container to integrate with an external API. The Wazuh Docker image doesn’t include this package, although I’ve opened a PR and am waiting for review (wazuh/wazuh-docker#2000
). Using command and args, we can override the startup or add additional packages. Please consider this.