Update terraform

Author: moritzkoerber

.azuredevops/deploy-infrastructure.yaml

@@ -22,7 +22,7 @@ jobs:
       - task: TerraformInstaller@0
         displayName: "Install Terraform"
         inputs:
-          terraformVersion: "1.9.1"
+          terraformVersion: "1.10.5"
 
       - task: TerraformTaskV4@4
         displayName: "Initialize Terraform"
@@ -51,7 +51,7 @@ jobs:
         condition: eq(variables['terraformPlan.changesPresent'], 'true')
         inputs:
           command: "apply"
-          commandOptions: "main.tfplan -var env=${{ parameters.environment }}"
+          commandOptions: "main.tfplan"
           environmentServiceNameAzureRM: $(serviceConnection)
           provider: "azurerm"
           workingDirectory: "$(System.DefaultWorkingDirectory)/ops"

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 ---
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
@@ -11,13 +11,13 @@ repos:
           - --unsafe
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.6.5"
+    rev: "v0.9.4"
     hooks:
       - id: ruff
       - id: ruff-format
 
   - repo: https://github.com/sirosen/check-jsonschema
-    rev: 0.29.2
+    rev: 0.31.1
     hooks:
       - id: check-github-workflows
       - id: check-github-actions
@@ -29,9 +29,10 @@ repos:
         args: [--format, parsable, --strict]
 
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.95.0
+    rev: v1.97.0
     hooks:
       - id: terraform_fmt
+      - id: terraform_tflint
 
   - repo: https://github.com/sirwart/ripsecrets
     rev: v0.1.8

ops/providers.tf

@@ -3,7 +3,11 @@ terraform {
   required_providers {
     azurerm = {
       source  = "hashicorp/azurerm"
-      version = ">=3.111.0"
+      version = "~> 4.17"
+    }
+    random = {
+      source  = "hashicorp/random"
+      version = "~> 3.5"
     }
   }
   backend "azurerm" {

ops/stack.tf

@@ -8,8 +8,8 @@ resource "azurerm_resource_group" "af-rg" {
   name     = "af-rg-${var.env}"
   location = var.region
 }
-resource "azurerm_storage_account" "example-sa" {
-  name                              = "examplesa${var.env}${random_id.unique-id.hex}"
+resource "azurerm_storage_account" "main-sa" {
+  name                              = "mainsa${var.env}${random_id.unique-id.hex}"
   resource_group_name               = azurerm_resource_group.af-rg.name
   location                          = azurerm_resource_group.af-rg.location
   account_tier                      = "Standard"
@@ -32,9 +32,9 @@ resource "azurerm_storage_account" "example-sa" {
   }
 }
 
-resource "azurerm_storage_container" "example" {
-  name                 = "mycontainer"
-  storage_account_name = azurerm_storage_account.example-sa.name
+resource "azurerm_storage_container" "main-container" {
+  name               = "mycontainer"
+  storage_account_id = azurerm_storage_account.main-sa.id
 }
 
 resource "azurerm_key_vault" "af-kv" {