Skip to content

Commit fe32798

Browse files
moritzzimmerclaude
andauthored
fix: address copilot review feedback on terraform-lambda skill (#192)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0c7e8e2 commit fe32798

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

skills/terraform-lambda/SKILL.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@ If the user gives a one-liner like "create a Python Lambda triggered by SQS call
6262
```
6363

6464
Source code location varies by runtime — Go puts `main.go` and `go.mod` at the
65-
project root (idiomatic Go), while Python uses `src/app/`, Java uses `src/`,
66-
etc. Always consult [references/runtimes.md](references/runtimes.md) for the
67-
correct layout.
65+
project root (idiomatic Go), Python uses `app/` at the project root, .NET puts
66+
source files at root, Java uses the standard Gradle `src/main/java/` layout.
67+
Always consult [references/runtimes.md](references/runtimes.md) for the correct
68+
layout.
6869

6970
### Terraform files
7071

@@ -128,12 +129,11 @@ output "invoke_arn" {
128129
```
129130
- Default architecture: `["arm64"]` (Graviton — better price/performance)
130131
- **Runtime versions**: Do not rely on your training data for Lambda runtime
131-
identifiers — they go stale quickly (e.g., `java21` is outdated, `java25`
132-
is current). Before generating code, look up the latest runtime by searching
133-
the web for "AWS Lambda supported runtimes" or checking
134-
`https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html`. If you
135-
cannot verify, leave a `# TODO: verify this is the latest runtime` comment
136-
next to the runtime value so the user knows to check.
132+
identifiers — they go stale quickly. Before generating code, look up the
133+
latest runtime by searching the web for "AWS Lambda supported runtimes" or
134+
checking `https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html`.
135+
If you cannot verify, leave a `# TODO: verify this is the latest runtime`
136+
comment next to the runtime value so the user knows to check.
137137
- Always include `tags = { managed_by = "terraform" }`
138138

139139
For runtime-specific settings, event source patterns, and the full variable

skills/terraform-lambda/references/variables.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Everything else is optional.
2121
| `architectures` | `list(string)` | `null` | `["x86_64"]` or `["arm64"]` |
2222
| `description` | `string` | `""` | What the function does |
2323
| `handler` | `string` | `""` | Function entrypoint |
24-
| `runtime` | `string` | `""` | Runtime identifier (e.g., `python3.14`, `provided.al2023`) |
24+
| `runtime` | `string` | `""` | Lambda runtime identifier — look up current values in AWS docs |
2525
| `package_type` | `string` | `"Zip"` | `Zip` or `Image` |
2626
| `publish` | `bool` | `false` | Publish as new version on each change |
2727
| `timeout` | `number` | `3` | Execution timeout in seconds |

0 commit comments

Comments
 (0)