fix(erpc:PLA-1610): harden consensus and HyperEVM filtering by 0x666c6f · Pull Request #93 · morpho-org/erpc

0x666c6f · 2026-06-24T10:41:28Z

Summary

Fail closed when consensus wait caps fire before enough valid participants respond.
Enforce required participant tag quotas against final valid consensus responses.
Tighten HyperEVM system-transaction filtering while validating original upstream blocks first.

Changes

Add wait-cap, required-participant, and slow-required-participant regression coverage in consensus tests.
Require HyperEVM filtered transactions to match multiple zero-value system fields, not just zero gas price.
Validate HyperEVM blocks before post-processing filters remove system transactions, with all-system transactionsRoot regression coverage.
Update consensus docs and existing hedge tests for explicit non-wait-cap timing.

Linear

PLA-1610: https://linear.app/morpho-labs/issue/PLA-1610/harden-erpc-consensus-and-evm-cache-correctness

aikido-pr-checks · 2026-06-24T10:41:58Z

+		Action: func(a *consensusAnalysis) *slotResult {
+			return &slotResult{
+				Error: common.NewErrConsensusLowParticipants(
+					"not enough required consensus participants: "+strings.Join(a.missingRequiredParticipants(), ", "),


missingRequiredParticipants() is invoked twice; call it once, store the result, and reuse it for length check and join to avoid redundant computation

Details

✨ AI Reasoning
The Action builds an error string by calling missingRequiredParticipants() twice (once to test length and again to produce the joined string). This re-computes the same slice twice. Capture the slice once and reuse it to avoid redundant work and make intent clearer.

🔧 How do I fix it?
Rewrite the snippet in the simpler, behavior-equivalent form: return a boolean expression directly instead of if cond return true else return false, avoid using lists when they are guaranteed to contain one element, etc.

_{Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.}
_{Reply @AikidoSec ignore: [REASON] to ignore this issue.}
_{More info}

Copilot

Pull request overview

Hardens eRPC’s consensus behavior under wait caps and required-participant quotas, and tightens HyperEVM system-transaction filtering to prevent invalid/undesired transactions from affecting block handling.

Changes:

Consensus: fail closed when wait caps fire before reaching agreementThreshold, and enforce requiredParticipants quotas against valid responses.
HyperEVM: strengthen system-transaction identification (multiple zero-ish fields) and run filtering before block validation.
Tests/docs: add/adjust regression coverage and update consensus documentation to reflect the new rule ordering/semantics.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`erpc/networks_hedge_cancel_test.go`	Makes hedge/consensus tests explicit about wait-cap timing to avoid ambiguous behavior.
`docs/pages/config/failsafe/consensus.mdx`	Updates docs to reflect fail-closed wait-cap semantics and strict required-participant enforcement (26 rules).
`consensus/wait_cap_test.go`	Adds regression tests for fail-closed behavior below threshold and updates existing wait-cap expectations.
`consensus/rules.go`	Introduces new top-priority rules for wait-capped low participants and missing required-participant quotas.
`consensus/quota.go`	Updates quota semantics comments to match strict enforcement in analysis.
`consensus/quota_test.go`	Adds unit coverage ensuring required participant quotas can reject an otherwise “winning” result.
`consensus/executor.go`	Propagates wait-cap state into analysis to support fail-closed rule evaluation.
`consensus/analysis.go`	Adds `waitCapped` to analysis and implements required-participant quota checking over valid responses.
`common/config.go`	Updates `ConsensusPolicyConfig.RequiredParticipants` comment to reflect fail-closed semantics.
`architecture/evm/eth_getBlockByNumber.go`	Moves HyperEVM filtering before validation and tightens system-tx detection fields.
`architecture/evm/eth_getBlockByNumber_test.go`	Updates fixtures/assertions to ensure only true system txs are filtered on HyperEVM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 	if analysis == nil {
-		analysis = newConsensusAnalysis(e.logger, ctx, e.config, responses)
+		analysis = newConsensusAnalysisWithOptions(e.logger, ctx, e.config, responses, waitCapped)
+		winner = e.determineWinner(lg, analysis)
+	} else if waitCapped {
+		analysis = newConsensusAnalysisWithOptions(e.logger, ctx, e.config, responses, true)


devin-ai-integration

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

fix(PLA-1610): harden consensus and HyperEVM filtering

bc43208

Copilot AI review requested due to automatic review settings June 24, 2026 10:41

0x666c6f self-assigned this Jun 24, 2026

Copilot started reviewing on behalf of 0x666c6f June 24, 2026 10:41 View session

aikido-pr-checks Bot reviewed Jun 24, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

fix(PLA-1610): simplify consensus finalization

a70e832

This comment was marked as resolved.

Sign in to view

Copilot AI reviewed Jun 24, 2026

View reviewed changes

fix(PLA-1610): wait for required consensus participants

f317e6a

Copilot AI review requested due to automatic review settings June 24, 2026 10:48

Copilot started reviewing on behalf of 0x666c6f June 24, 2026 10:48 View session

devin-ai-integration Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread architecture/evm/eth_getBlockByNumber.go

fix(PLA-1610): validate HyperEVM blocks before filtering

53ccef7

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread consensus/wait_cap_test.go

test(PLA-1610): pin wait cap regression

1d32800

Copilot AI review requested due to automatic review settings June 24, 2026 10:56

Copilot started reviewing on behalf of 0x666c6f June 24, 2026 10:56 View session

0x666c6f added 2 commits June 24, 2026 13:00

fix(PLA-1610): preserve short-circuit winner

27ddbef

fix(PLA-1610): clarify consensus finalization

5df8a54

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread consensus/wait_cap_test.go Outdated

test(PLA-1610): cancel wait cap stragglers

6e2e3cb

Copilot AI review requested due to automatic review settings June 24, 2026 11:08

Copilot started reviewing on behalf of 0x666c6f June 24, 2026 11:08 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread consensus/rules.go

fix(PLA-1610): enforce sendrawtx required quotas

462d8f3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(erpc:PLA-1610): harden consensus and HyperEVM filtering#93

fix(erpc:PLA-1610): harden consensus and HyperEVM filtering#93
0x666c6f wants to merge 9 commits into
morpho-mainfrom
feature/pla-1610-harden-erpc-consensus-and-evm-cache-correctness

0x666c6f commented Jun 24, 2026 •

edited

Loading

Uh oh!

aikido-pr-checks Bot Jun 24, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

0x666c6f commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Linear

Uh oh!

aikido-pr-checks Bot Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0x666c6f commented Jun 24, 2026 •

edited

Loading