Merge remote-tracking branch 'metamorpho/main' into merge-04-2026#89
Merge remote-tracking branch 'metamorpho/main' into merge-04-2026#89MathisGD wants to merge 33 commits into
Conversation
[Certora] Fix tokens reallocate
Compatibility via-ir
[Certora] Update to prover v8
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
docs: morpho vault wording
Harmonize pinned GitHub Actions `uses:` refs to the latest major version across common dependencies. Files updated: .github/workflows/certora.yml, .github/workflows/formatting.yml, .github/workflows/foundry.yml, .github/workflows/hardhat.yml, .github/workflows/npm-release.yml
…s-20260416 ci: pin GitHub Actions refs to commit SHAs
Resolves conflicts with main by keeping the deletions of hardhat.yml and npm-release.yml workflows (which this PR removes) while preserving the pinned GitHub Actions SHAs introduced on main for the remaining workflows (certora.yml, formatting.yml, foundry.yml).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f909db60fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
this file should be deleted (or updated) if we remove erc4626-tests
There was a problem hiding this comment.
how can the ci be passing now
There was a problem hiding this comment.
when I run forge test this file is not tested weirdly
There was a problem hiding this comment.
I have no idea, plus we have the following issue (should remove ../) but tests still pass:
Unable to resolve imports: "../../src/MetaMorphoV1_1Factory.sol" in "/home/runner/work/metamorpho-v1.1/metamorpho-v1.1/test/MetaMorphoFactoryTest.sol"
There was a problem hiding this comment.
how can the ci be passing now
I think I get it, it's because it can find it in lib/openzeppelin-contracts/lib/erc4626-tests/
There was a problem hiding this comment.
when I run forge test this file is not tested weirdly
weird, it's tested for me. Can you try rerunning by removing everything in the test folder except what's inside test/helpers + ERC4626ComplianceTest.sol + ERC4626Test.sol ?
There was a problem hiding this comment.
💡 Codex Review
Correct factory test import to stay inside repo
This import path is now invalid after moving the test from test/forge to test: ../../src/MetaMorphoV1_1Factory.sol resolves to /workspace/src/MetaMorphoV1_1Factory.sol, which does not exist in this repository. As a result, forge test/CI compilation fails before tests run. Update the path to the repo-local src directory (from test/, that should be ../src/...).
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Let's keep the changes in this PR minimal, and we can do an update of metamorpho and merge again if needed
There was a problem hiding this comment.
So notably I think it would be good to roll back the changes of forge-std, to have the same version between metamorpho and metamorpho v1.1. Even though we probably want some of those new commits
There was a problem hiding this comment.
List of changes that we might want on both repos:
- update dependencies
- Merge remote-tracking branch 'metamorpho/main' into merge-04-2026 #89 (comment)
via-ir->via_irinfoundry.toml
4 participants
merge metamorpho. updated forge-std while debugging, can rollback if needed