Fix#154 관리자 문의게시판 상태가 제대로 반영되지 않는 현상#155
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Summary of Changes
Hello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in the admin inquiry board where the status of inquiries was not being correctly reflected or filtered. The changes primarily involve aligning the frontend's understanding of inquiry statuses with the actual Korean string values ("완료" for completed, "미응답" for unanswered) returned by the API, and ensuring the UI and filtering logic correctly interpret these values. Additionally, it improves data freshness by invalidating the inquiry list cache upon status updates.
Highlights
- API Type Definition Update: Updated the
InquiryResponseBodyinterface inmosu-admin/src/api/inquiry/inquiry-list.tsto reflect the actual Korean status strings ("미응답", "완료") received from the API, replacing the previous English enumerations ("PENDING", "COMPLETED"). - UI Display Logic Correction: Modified
mosu-admin/src/components/inquiryboard/inquiry/InquiryPanel.tsxto correctly display inquiry statuses in the UI. The badge variant, styling, and displayed text now correctly use "완료" for completed inquiries and "미응답" for unanswered ones, aligning with the updated API response. - Inquiry Filtering Logic Adjustment: Updated
mosu-admin/src/hooks/inquiry/useInquiryFilters.tsto filter inquiries based on the correct Korean status strings ("완료" for answered, "미응답" for unanswered), resolving discrepancies in the filtering mechanism. - Cache Invalidation Enhancement: Added a cache invalidation for the inquiry list (
inquiryQueryKeys.list()) inmosu-admin/src/api/inquiry/inquiry-update-reply.tsafter an inquiry reply is updated. This ensures the main inquiry list view reflects the latest status changes immediately without requiring a manual refresh.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
📝 추가 및 변경된 파일총 4개 파일 변경 |
✅ Mosu Admin 빌드가 성공적으로 완료되었습니다!📋 빌드 결과
🚀 다음 단계코드 리뷰 후 머지하면 프로덕션에 배포됩니다. |
| content: string; | ||
| author: string; | ||
| status: "PENDING" | "COMPLETED"; | ||
| status: "미응답" | "완료"; |
| } | ||
| > | ||
| {row.status === "COMPLETED" ? "완료" : "미응답"} | ||
| {row.status === "완료" ? "완료" : "미응답"} |
| if (selectedFilters.answered && inquiry.status === "완료") return true; | ||
| if (selectedFilters.unanswered && inquiry.status === "미응답") return true; |
✅ Linked Issue
🔍 What I did
TODO