Merge pull request #351 from mosu-dev/develop

[배포]: 카카오 중복 판단 로직 추가 및 로그 제거

Author: polyglot-k

src/main/java/life/mosu/mosuserver/application/auth/SignUpService.java

@@ -23,13 +23,11 @@ public class SignUpService {
     @Transactional
     public Token signUp(final SignUpAccountRequest request) {
         UserJpaEntity user = doAccountStep(request);
-        log.info("User signed up successfully: {}", user);
         return authTokenManager.generateAuthToken(user);
     }
 
     private UserJpaEntity doAccountStep(SignUpAccountRequest request) {
         UserJpaEntity user = request.toAuthEntity(passwordEncoder);
-        log.info("log : {}", user);
         return signUpAccountStepProcessor.process(user);
     }
 }

src/main/java/life/mosu/mosuserver/application/auth/kmc/tx/KmcContext.java

@@ -1,12 +1,13 @@
 package life.mosu.mosuserver.application.auth.kmc.tx;
 
-import life.mosu.mosuserver.domain.auth.signup.Token;
+import life.mosu.mosuserver.domain.auth.token.Token;
 
 public record KmcContext(
         String certNum,
         Long expiration,
         Boolean isSuccess
 ) {
+
     public static KmcContext ofSuccess(String certNum, Long expiration) {
         return new KmcContext(certNum, expiration, true);
     }
@@ -17,8 +18,8 @@ public static KmcContext ofFailure(String certNum) {
 
     public Token toToken() {
         return Token.of(
-            this.certNum,
-            this.expiration
+                this.certNum,
+                this.expiration
         );
     }
 }

src/main/java/life/mosu/mosuserver/application/auth/kmc/tx/KmcTxEventListener.java

@@ -1,7 +1,7 @@
 package life.mosu.mosuserver.application.auth.kmc.tx;
 
-import life.mosu.mosuserver.domain.auth.signup.Token;
-import life.mosu.mosuserver.domain.auth.signup.TokenRepository;
+import life.mosu.mosuserver.domain.auth.token.Token;
+import life.mosu.mosuserver.domain.auth.token.TokenRepository;
 import life.mosu.mosuserver.global.tx.TxFailureHandler;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;

src/main/java/life/mosu/mosuserver/application/auth/processor/SignUpAccountStepProcessor.java

@@ -20,12 +20,28 @@ public class SignUpAccountStepProcessor implements StepProcessor<UserJpaEntity,
     @Transactional
     @Override
     public UserJpaEntity process(UserJpaEntity user) {
-        if (userRepository.existsByPhoneNumber(user.getOriginPhoneNumber())) {
-            throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);
-        } else if (userRepository.existsByLoginId(user.getLoginId())) {
+
+        validateForNewSignUp(user);
+
+        return userRepository.save(user);
+    }
+
+    private void validateForNewSignUp(UserJpaEntity user) {
+
+        userRepository.findByPhoneNumber(user.getOriginPhoneNumber())
+                .ifPresent(existingUser -> {
+                    if (existingUser.isPendingUser()) {
+                        switch (existingUser.getProvider()) {
+                            case MOSU:
+                                throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);
+                            case KAKAO:
+                                throw new CustomRuntimeException(ErrorCode.KAKAO_DUPLICATED);
+                        }
+                    }
+                });
+
+        if (userRepository.existsByLoginId(user.getLoginId())) {
             throw new CustomRuntimeException(ErrorCode.USER_ALREADY_EXISTS);
         }
-        log.info("Processing user sign-up: {}", user);
-        return userRepository.save(user);
     }
 }

src/main/java/life/mosu/mosuserver/application/auth/provider/OneTimeTokenProvider.java

@@ -8,19 +8,20 @@
 import io.jsonwebtoken.security.Keys;
 import java.security.Key;
 import java.util.Date;
-import life.mosu.mosuserver.domain.auth.signup.Token;
-import life.mosu.mosuserver.domain.auth.signup.TokenRepository;
+import life.mosu.mosuserver.domain.auth.token.Token;
+import life.mosu.mosuserver.domain.auth.token.TokenRepository;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Service;
+
 @Slf4j
 @Service
 public class OneTimeTokenProvider {
-    private final TokenRepository tokenRepository;
+
     private static final String tokenType = "ONE_TIME";
     private static final String TOKEN_TYPE_KEY = "type";
     private static final String PHONE_NUMBER_KEY = "phone";
-
+    private final TokenRepository tokenRepository;
     private final Long expireTime;
     private final Key key;
 

src/main/java/life/mosu/mosuserver/application/notify/NotifyService.java

@@ -37,15 +37,10 @@ public void notify(LunaNotificationEvent event) {
         NotifySender<LunaNotificationVariable> sender = senderResolver.resolve(event.status());
 
         sender.send(phone, event, notifyVariable);
-        log.info("[NotifyService] 알림톡 전송 성공: userId={}, status={}", event.userId(), event.status());
     }
 
     @Recover
     public void recover(CustomRuntimeException exception, LunaNotificationEvent event) {
-        log.warn(
-                "[NotifyService] 알림톡 전송 실패: userId={}, status={}, reason={}",
-                event.userId(), event.status(), exception.getMessage()
-        );
         DiscordExceptionNotifyEventRequest request = DiscordExceptionNotifyEventRequest.of(
                 exception.getCause() != null ? exception.getCause().toString() : "N/A",
                 exception.getMessage(),

src/main/java/life/mosu/mosuserver/application/oauth/OAuthUserPersistenceProcessor.java

@@ -17,20 +17,23 @@ public class OAuthUserPersistenceProcessor implements StepProcessor<OAuthUserInf
 
     private final UserJpaRepository userRepository;
 
-    /**
-     * this method is processing OAuthUserInfo to UserJpaEntity that is Get or Create.
-     *
-     * @param info
-     * @return
-     */
     @Override
     @Transactional
     public UserJpaEntity process(final OAuthUserInfo info) {
         return userRepository.findByPhoneNumber(
                         PhoneNumberUtil.formatPhoneNumber(info.phoneNumber()))
                 .map(existingUser -> {
-                    if (existingUser.isMosuUser()) {
-                        throw new OAuthException("DUPLICATE");
+                    switch (existingUser.getProvider()) {
+                        case MOSU:
+                            if (existingUser.isPendingUser()) {
+                                throw new OAuthException("DUPLICATE");
+                            }
+                            break;
+                        case KAKAO:
+                            if (existingUser.isPendingUser()) {
+                                throw new OAuthException("KAKAO_DUPLICATE");
+                            }
+                            break;
                     }
                     existingUser.updateOAuthUser(
                             info.gender(),

src/main/java/life/mosu/mosuserver/application/oauth/OAuthUserService.java

@@ -46,8 +46,6 @@ public OAuth2User loadUser(final OAuth2UserRequest userRequest)
                     .orElse(false);
         }
 
-        log.info("동의 여부{}", agreedToMarketing);
-
         final String registrationId = userRequest.getClientRegistration().getRegistrationId();
         final String userNameAttributeName = userRequest.getClientRegistration()
                 .getProviderDetails()

src/main/java/life/mosu/mosuserver/application/user/UserService.java

@@ -1,6 +1,5 @@
 package life.mosu.mosuserver.application.user;
 
-import life.mosu.mosuserver.domain.profile.entity.ProfileJpaEntity;
 import life.mosu.mosuserver.domain.user.entity.UserJpaEntity;
 import life.mosu.mosuserver.domain.user.repository.UserJpaRepository;
 import life.mosu.mosuserver.global.exception.CustomRuntimeException;
@@ -31,13 +30,6 @@ public UserJpaEntity getUserOrThrow(Long userId) {
         );
     }
 
-    public void syncUserInfoFromProfile(UserJpaEntity user, ProfileJpaEntity profile) {
-        if (user.isMosuUser()) {
-            user.updateUserInfo(profile.getGender(), profile.getUserName(),
-                    profile.getPhoneNumber(), profile.getBirth());
-        }
-    }
-
     public Long saveOrGetUser(UserJpaEntity user) {
         return userJpaRepository.findByPhoneNumber(
                         PhoneNumberUtil.formatGuestPhoneNumber(user.getPhoneNumber()))