Skip to content

Update .po files to preserve translations when adding %$ conversion specifier#3274

Draft
Copilot wants to merge 6 commits into
enh/conversion-specifierfrom
copilot/sub-pr-3273
Draft

Update .po files to preserve translations when adding %$ conversion specifier#3274
Copilot wants to merge 6 commits into
enh/conversion-specifierfrom
copilot/sub-pr-3273

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 15, 2026

  • Update all backend .po files to include %$ in the msgid for file name validation message
  • Update corresponding msgstr translations to include %$ where applicable
  • Test the changes to ensure translations still work correctly
  • Fix translations that were missed by the initial automated update
  • Fix inconsistent trailing period in Spanish translation
  • Revert unwanted .pot file regeneration that added line breaks (project uses --no-wrap)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Copilot AI changed the title [WIP] Allow motion's %$ conversion specifier Update .po files to preserve translations when adding %$ conversion specifier Feb 15, 2026
Copilot AI requested a review from MichaIng February 15, 2026 23:28
@MichaIng
Copy link
Copy Markdown
Member

@copilot
Well done, I am glad you found and updated as well the translations where these %v parts were not at the end of the whole string.

But please revert commit d118e7a. We intentionally avoid the line breaks, adding --no-wrap to xgettext and msgmerge. They do compile well, including msgfmt to generate the .mo files (which is done via CI and Weblate, no need to do manually).

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Can you clarify where exactly this happened? I do not see anything in this regards in the agent session log, and all requested changes have been successfully applied.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 15, 2026

@copilot
Well done, I am glad you found and updated as well the translations where these %v parts were not at the end of the whole string.

...

Reverted the .pot file regeneration that added line breaks. The file now maintains the --no-wrap format as intended while still including the %$ conversion specifier.

Commit: 67bb98e

@MichaIng MichaIng added this to the v0.43.2 milestone Mar 1, 2026
@MichaIng MichaIng force-pushed the enh/conversion-specifier branch from 16291f9 to 98f7513 Compare March 4, 2026 22:54
Copilot AI and others added 6 commits March 4, 2026 23:57
Co-authored-by: MichaIng <28480705+MichaIng@users.noreply.github.com>
Co-authored-by: MichaIng <28480705+MichaIng@users.noreply.github.com>
Co-authored-by: MichaIng <28480705+MichaIng@users.noreply.github.com>
Co-authored-by: MichaIng <28480705+MichaIng@users.noreply.github.com>
Co-authored-by: MichaIng <28480705+MichaIng@users.noreply.github.com>
@MichaIng MichaIng force-pushed the copilot/sub-pr-3273 branch from 67bb98e to 90ffc36 Compare March 4, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants