Skip to content

Fix duplicate request snapshotting URL as name #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gschier merged 6 commits into from
Apr 23, 2026
Merged

Fix duplicate request snapshotting URL as name #429

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85260ab
Fix duplicate request snapshotting URL as name
gschier Mar 17, 2026
0979398
Refactor ternary to if-statement for readability
gschier Mar 17, 2026
df089e6
Use resolvedModelName for conflict detection on named requests
gschier Mar 17, 2026
f283b02
Remove redundant resolvedModelName call for non-empty names
gschier Mar 17, 2026
356b8ea
Remove unnecessary typecast for model.name
gschier Mar 17, 2026
d2a3f7a
Simplify back to ternary now that typecast is gone
gschier Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/yaak-models/guest-js/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,10 @@ export function duplicateModel<M extends AnyModel["model"], T extends ExtractMod
throw new Error("Failed to duplicate null model");
}

// If the model has a name, try to duplicate it with a name that doesn't conflict
let name = "name" in model ? resolvedModelName(model) : undefined;
if (name != null) {
// If the model has an explicit (non-empty) name, try to duplicate it with a name that doesn't conflict.
// When the name is empty, keep it empty so the display falls back to the URL.
let name = "name" in model ? model.name : undefined;
if (name) {
const existingModels = listModels(model.model);
for (let i = 0; i < 100; i++) {
const hasConflict = existingModels.some((m) => {
Expand Down
Loading