feat: expand i18n and Vietnamese source support#12
Conversation
Signed-off-by: nguyen quoc hung <vatchatyeutoi@gmail.com>
Signed-off-by: nguyen quoc hung <vatchatyeutoi@gmail.com>
Signed-off-by: nguyen quoc hung <vatchatyeutoi@gmail.com>
|
@nguyen-hung-dev 感谢这个非常有价值的贡献!i18n 基建对项目长期的国际化意义很大。 当前状态:此 PR 涉及 61 文件、+5,107/-1,129 行的大规模 refactor,当前项目处在 EMNLP 2026 ARR 投稿准备期(5/25 截稿),按内部节奏约定,这段时间我们 冻结所有非 bugfix 的功能变更,专注稳定性。即使 CI 通过,61 文件的 review 深度 + 破 UI / 打包 build 的潜在风险对投稿窗口过高。 计划:ARR 录用通知预期在 2026-08-20 前后。此 PR 将在 8/20 后 优先 review 合并。届时我会:
PR 不 close,仍保留开放状态追踪。感谢您的耐心! |
|
Hi @nguyen-hung-dev — thank you for the substantial work here. 13k+ lines across 100+ files with full Vietnamese support is a serious contribution and the multilingual ambition is genuinely appreciated. Two distinct concerns bundled togetherLooking carefully, this PR contains two largely independent pieces of work: (A) Frontend i18n — well-scoped, low risk:
(B) Vietnamese source pipeline — broader surface, touches L3 files:
Per our Project timelineWe're submitting to ARR by May 25, 2026 (~2.5 weeks out). The paper's §3.7 contamination-free eval and §3.3 single-root claim both depend on the current pipeline producing reproducible numbers on the 5-novel benchmark. Modifying the L3 files in (B) before submission would mean re-running the full benchmark and updating paper tables — not feasible at this stage. Proposed pathCould you split this into two PRs?
Two practical notes regardless:
If splitting isn't workable on your end, I'm happy to keep this PR open and we'll review post-May 25 as a single unit. Just slower. Truly appreciate the multilingual vision and the careful structure of the Vietnamese adapter. Looking forward to landing this properly. — Lei 中文 TL;DR(备注,方便后续中文读者快速理解): 感谢非常用心的贡献。这个 PR 实际打包了两件事 — 前端 i18n(低风险,可单独合)和越南语抽取管线支持(新增 1100+ 行模块 + 改动多个 建议路径:拆成 PR-12A(纯 i18n,本周可合)+ PR-12B(越南语管线,5/25 后认真 review)。如果不愿拆,整体保留到 5/25 后处理也 OK,只是慢一些。 |
|
Thanks for the substantial contribution! This is a well-structured i18n framework (13K+ lines, complete provider + locale infrastructure). Heads up: the project is currently in the ACL Rolling Review evaluation cycle (reviews land ~July 7-13, rebuttal closes ~July 13). To avoid disruptive main-branch changes during the reviewer reproducibility window, I'll do a careful review of this PR after the July rebuttal period ends. Two things before merge can be considered:
I'll re-engage on this in mid-July. Apologies for the delay, and thanks for your patience! |
Summary
Scope
Validation
Closes #11