Maintenance

[Mainbird]

Summary by CodeRabbit

• New Features

  • Added Typoscript linting support to development tooling.

• Chores

  • Adjusted repository export settings to change which files are included.
  • Modernized PHP code style using newer language features and annotations.
  • Updated development and testing configuration and scripts for linting and maintenance.

[coderabbitai]

Warning

Rate limit exceeded

@Mainbird has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d76127d7-5f5a-4239-bf8d-d1c9ca862cec

📥 Commits

Reviewing files that changed from the base of the PR and between d0dd98b and dbf51b4.

📒 Files selected for processing (7)

• .gitattributes
• .gitignore
• Classes/Page/AssetRenderer.php
• Classes/ViewHelpers/Asset/CssViewHelper.php
• Tests/CGL/composer.json
• Tests/CGL/rector.php
• Tests/CGL/typoscript-lint.yml

📝 Walkthrough

Walkthrough

This PR updates export rules, modernizes two PHP classes (adds an #[\Override] and uses constructor property promotion), adds Typoscript linting configuration and composer script, and cleans up Rector and .gitignore entries. Changes are limited to tooling/config and small PHP refactors.

Changes

Cohort / File(s)	Summary
Git Export & Ignore /.gitattributes, /.gitignore	Adjusted export-ignore entries: added /Tests, /composer-unused.php, /version-bumper.yaml; removed export-ignore for several dev configs. Removed three entries from .gitignore so those files become tracked.
Page Asset Renderer Classes/Page/AssetRenderer.php	Added #[\Override] attribute to renderStyleSheets() method (annotation only; signature and logic unchanged).
ViewHelper Constructor Promotion Classes/ViewHelpers/Asset/CssViewHelper.php	Replaced explicit property + assignment with PHP 8 constructor property promotion (protected AssetCollector $assetCollector). No behavior change.
Typoscript Linting Setup Tests/CGL/composer.json, Tests/CGL/typoscript-lint.yml	Added lint:typoscript script to composer.json and added typoscript-lint.yml with indentation/sniff rules and file patterns for *.typoscript and *.tsconfig.
Rector CGL Cleanup Tests/CGL/rector.php	Removed ExtEmConfRector import, deleted a commented PHP version guidance block and a skip rule for ExtensionBuilder paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor: restructure project files and update CGL scripts for improved coding standards #13: Overlapping changes to CGL tooling/config (Tests/CGL/*) and related constructor/promotions.
• View helper update #9: Edits to CssViewHelper.php touching constructor/property injection and attributes.
• fix: phpstan issues #4: Prior modifications to CssViewHelper class; likely to conflict or overlap.

Suggested reviewers

• konradmichalik

Poem

🐰 I hopped through code with nimble feet,
Promoted props and overrides neat,
Linting checks now take the stage,
Cleaner exports, trimmed old page,
A happy rabbit seals this feat.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Maintenance' is vague and generic, using a non-descriptive term that fails to convey meaningful information about the changeset's primary objectives.	Use a more specific title that summarizes the main changes, such as 'Add TypeScript linting and modernize constructor syntax' or 'Update project tooling and configuration'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch maintenance

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Tests/CGL/composer.json`:
- Line 66: The "lint:typoscript" composer script currently runs "@php
typoscript-lint", which bypasses Composer's bin proxy; update the
"lint:typoscript" script to invoke the Composer-generated binary proxy (i.e. use
the bin proxy name provided by the helmich/typo3-typoscript-lint package instead
of prepending "@php") so Composer resolves the executable from vendor binaries
correctly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2a7b197c-8d5c-4980-ad69-50217a894a84

📥 Commits

Reviewing files that changed from the base of the PR and between 748b28b and 67de1d8.

📒 Files selected for processing (6)

• .gitattributes
• Classes/Page/AssetRenderer.php
• Classes/ViewHelpers/Asset/CssViewHelper.php
• Tests/CGL/composer.json
• Tests/CGL/rector.php
• Tests/CGL/typoscript-lint.yml

💤 Files with no reviewable changes (1)

• Tests/CGL/rector.php