Feature/fluid namespace#18
Conversation
📝 WalkthroughWalkthroughThis PR migrates the project version toolbar item from a legacy HTML template to a new TYPO3 Fluid-based template. The change includes editor configuration for HTML file indentation, a Fluid namespace alias registration enabling the ChangesProject Version Toolbar with Fluid Templates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html (1)
1-13:⚠️ Potential issue | 🟠 Major | ⚡ Quick winTemplate filename likely won’t match the current render target.
ProjectVersionItem.phprendersToolbarItems/ProjectVersionItem.html, but this PR addsProjectVersionItem.fluid.html. Unless there is custom resolver logic, the new template won’t be picked up at runtime. Please either rename this file toProjectVersionItem.htmlor update the render call accordingly (Line 31-61 inClasses/Backend/ToolbarItems/ProjectVersionItem.php).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html` around lines 1 - 13, The template filename doesn't match what's rendered by Classes/Backend/ToolbarItems/ProjectVersionItem.php (it expects ToolbarItems/ProjectVersionItem.html), so either rename Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html to ProjectVersionItem.html or update the render call in ProjectVersionItem.php (where the template is resolved/rendered) to point to "ProjectVersionItem.fluid.html"; locate the renderTemplate/renderPartial call in the ProjectVersionItem class and make the template name consistent with the new file name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html`:
- Around line 1-13: The template filename doesn't match what's rendered by
Classes/Backend/ToolbarItems/ProjectVersionItem.php (it expects
ToolbarItems/ProjectVersionItem.html), so either rename
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html to
ProjectVersionItem.html or update the render call in ProjectVersionItem.php
(where the template is resolved/rendered) to point to
"ProjectVersionItem.fluid.html"; locate the renderTemplate/renderPartial call in
the ProjectVersionItem class and make the template name consistent with the new
file name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9b38bc14-02de-4b99-b3be-5863ba75ec65
📒 Files selected for processing (4)
.editorconfigConfiguration/Fluid/Namespaces.phpResources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.htmlResources/Private/Templates/ToolbarItems/ProjectVersionItem.html
💤 Files with no reviewable changes (1)
- Resources/Private/Templates/ToolbarItems/ProjectVersionItem.html
Summary by CodeRabbit