Skip to content

Feature/fluid namespace#18

Merged
Mainbird merged 2 commits into
mainfrom
feature/fluid-namespace
Jun 8, 2026
Merged

Feature/fluid namespace#18
Mainbird merged 2 commits into
mainfrom
feature/fluid-namespace

Conversation

@Mainbird

@Mainbird Mainbird commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated editor configuration for HTML file formatting
    • Refactored project version display template system

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR migrates the project version toolbar item from a legacy HTML template to a new TYPO3 Fluid-based template. The change includes editor configuration for HTML file indentation, a Fluid namespace alias registration enabling the tb namespace, and a new template with CSS styling and conditional version rendering logic.

Changes

Project Version Toolbar with Fluid Templates

Layer / File(s) Summary
Fluid Configuration Infrastructure
.editorconfig, Configuration/Fluid/Namespaces.php
.editorconfig adds HTML indentation rules using tabs; new Namespaces.php registers the tb alias for MoveElevator\Typo3Toolbox\ViewHelpers to enable Fluid template namespace support.
Project Version Toolbar Template
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html
New Fluid template replaces legacy HTML template with CSS styling for .topbar-header-project-version and conditional rendering that outputs a version toolbar item with actions-tag icon and version text when {version} is present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • move-elevator/typo3-toolbox#2: Replaced Resources/Private/Templates/ToolbarItems/ProjectVersionItem.html template with the new ProjectVersionItem.fluid.html implementation for the same toolbar item component.

Suggested reviewers

  • konradmichalik
  • hpa-move

Poem

🐰 A template takes flight, from HTML to Fluid so bright,
With namespaces bound and tabs configured right,
The version now renders with elegant grace,
A toolbar reborn in this bright Fluid space! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Feature/fluid namespace' directly relates to the main change: adding a Fluid namespace configuration file (Configuration/Fluid/Namespaces.php) that registers the 'tb' alias for view helpers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fluid-namespace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html (1)

1-13: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Template filename likely won’t match the current render target.

ProjectVersionItem.php renders ToolbarItems/ProjectVersionItem.html, but this PR adds ProjectVersionItem.fluid.html. Unless there is custom resolver logic, the new template won’t be picked up at runtime. Please either rename this file to ProjectVersionItem.html or update the render call accordingly (Line 31-61 in Classes/Backend/ToolbarItems/ProjectVersionItem.php).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html`
around lines 1 - 13, The template filename doesn't match what's rendered by
Classes/Backend/ToolbarItems/ProjectVersionItem.php (it expects
ToolbarItems/ProjectVersionItem.html), so either rename
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html to
ProjectVersionItem.html or update the render call in ProjectVersionItem.php
(where the template is resolved/rendered) to point to
"ProjectVersionItem.fluid.html"; locate the renderTemplate/renderPartial call in
the ProjectVersionItem class and make the template name consistent with the new
file name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html`:
- Around line 1-13: The template filename doesn't match what's rendered by
Classes/Backend/ToolbarItems/ProjectVersionItem.php (it expects
ToolbarItems/ProjectVersionItem.html), so either rename
Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html to
ProjectVersionItem.html or update the render call in ProjectVersionItem.php
(where the template is resolved/rendered) to point to
"ProjectVersionItem.fluid.html"; locate the renderTemplate/renderPartial call in
the ProjectVersionItem class and make the template name consistent with the new
file name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b38bc14-02de-4b99-b3be-5863ba75ec65

📥 Commits

Reviewing files that changed from the base of the PR and between 5364413 and 7e3a0dd.

📒 Files selected for processing (4)
  • .editorconfig
  • Configuration/Fluid/Namespaces.php
  • Resources/Private/Templates/ToolbarItems/ProjectVersionItem.fluid.html
  • Resources/Private/Templates/ToolbarItems/ProjectVersionItem.html
💤 Files with no reviewable changes (1)
  • Resources/Private/Templates/ToolbarItems/ProjectVersionItem.html

@Mainbird
Mainbird merged commit 7f89f88 into main Jun 8, 2026
2 checks passed
@Mainbird
Mainbird deleted the feature/fluid-namespace branch June 8, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants