Add '-Wno-error=deprecated-declarations' to mandatory Rolling CI jobs. (#3706)

Add new optional CI Rolling job that does fail on deprecations

Author: nbbrooks

.github/workflows/ci.yaml

@@ -20,10 +20,17 @@ jobs:
           - IMAGE: rolling-ci
             CCOV: true
             ROS_DISTRO: rolling
+            # Ignore deprecation errors from upstream packages on rolling
+            SUPPRESS_DEPRECATION_ERROR: true
           - IMAGE: rolling-ci
             ROS_DISTRO: rolling
             IKFAST_TEST: true
             CLANG_TIDY: pedantic
+            SUPPRESS_DEPRECATION_ERROR: true
+          - IMAGE: rolling-ci
+            ROS_DISTRO: rolling
+            # Non-blocking job to surface deprecation warnings
+            DEPRECATION_CHECK: true
           - IMAGE: humble-ci
             ROS_DISTRO: humble
           - IMAGE: jazzy-ci
@@ -51,7 +58,7 @@ jobs:
         -DCMAKE_SHARED_LINKER_FLAGS=-fuse-ld=lld
         -DCMAKE_MODULE_LINKER_FLAGS=-fuse-ld=lld
         -DCMAKE_BUILD_TYPE=${{ matrix.env.CCOV && 'Debug' || 'Release'}}
-        -DCMAKE_CXX_FLAGS="-Werror $CXXFLAGS${{ matrix.env.CCOV && ' --coverage -O2 -fno-omit-frame-pointer' || ''}}"
+        -DCMAKE_CXX_FLAGS="-Werror ${{ matrix.env.SUPPRESS_DEPRECATION_ERROR && '-Wno-error=deprecated-declarations ' || ''}}$CXXFLAGS${{ matrix.env.CCOV && ' --coverage -O2 -fno-omit-frame-pointer' || ''}}"
       UPSTREAM_CMAKE_ARGS: "-DCMAKE_CXX_FLAGS=''"
       DOWNSTREAM_CMAKE_ARGS: -DCMAKE_CXX_FLAGS="-Wall -Wextra"
       CCACHE_DIR: ${{ github.workspace }}/.ccache
@@ -67,8 +74,9 @@ jobs:
       CXX: ${{ matrix.env.CLANG_TIDY && 'clang++' }}
       ADDITIONAL_DEBS: lld
 
-    name: ${{ matrix.env.IMAGE }}${{ matrix.env.CCOV && ' + ccov' || ''}}${{ matrix.env.IKFAST_TEST && ' + ikfast' || ''}}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' + clang-tidy (delta)' || ' + clang-tidy (all)') || '' }}
+    name: ${{ matrix.env.IMAGE }}${{ matrix.env.CCOV && ' + ccov' || ''}}${{ matrix.env.IKFAST_TEST && ' + ikfast' || ''}}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' + clang-tidy (delta)' || ' + clang-tidy (all)') || '' }}${{ matrix.env.DEPRECATION_CHECK && ' + deprecation check' || '' }}
     runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.env.DEPRECATION_CHECK || false }}
     steps:
       - name: "Free up disk space"
         if: matrix.env.CCOV