Fix RViz Cartesian execute crash under sim-time mismatch#3722
Open
chdkf wants to merge 1 commit into
Open
Conversation
|
Please target the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## humble #3722 +/- ##
==========================================
- Coverage 51.21% 51.20% -0.00%
==========================================
Files 407 407
Lines 30667 30667
==========================================
- Hits 15704 15701 -3
- Misses 14963 14966 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix null pointer dereference in computeCartesianPlan() under sim_time
Problem
In simulation setups where
/joint_statescarries sim_time stamps andRViz uses wall time,
move_group_->getCurrentState()always times out andreturns nullptr (wall time ~1.78×10⁹ s vs sim time ~tens of seconds, so
the 1-second wait in
waitForCurrentState(node->now(), 1s)never succeeds).Dereferencing the returned pointer crashes the RViz process with SIGSEGV.
Fix
Replace the blocking call with the PlanningSceneMonitor's already-tracked
state, consistent with all five other current-state accesses in this file:
-rt.setRobotTrajectoryMsg(*move_group_->getCurrentState(), trajectory);
+rt.setRobotTrajectoryMsg(planning_display_->getPlanningSceneRO()->getCurrentState(), trajectory);
Why this is correct
motion_planning_frame_planning.cppalready usesgetPlanningSceneRO()->getCurrentState().This was the only exception.
Reproduction