fix(moveit_cpp): load planning scene monitor params#3730
Open
liborw wants to merge 1 commit into
Open
Conversation
peci1
approved these changes
May 20, 2026
Contributor
peci1
left a comment
peci1
left a comment
There was a problem hiding this comment.
LGTM (but I haven't run-tested this).
One possible simplification is to remove the initializers of the member vars from the constructor and pass the default values to get_param_or.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load all planning_scene_monitor_options values from node parameters so MoveItPy config_dict can override joint_state_topic and related settings. Fixes #3729.