resolute: raise octomap version pin to allow 1.10#3755
Merged
Conversation
cc5fb89 to
55eba86
Compare
moveit2 already treats octomap like any other system dependency since PR moveit#2881 (which switched moveit_core / moveit_ros/occupancy_map_monitor from <depend>octomap</depend> to <depend>liboctomap-dev</depend>). The 1.9.7...<1.10.0 range in CMakeLists.txt was the leftover artifact of moveit#2862's defensive workaround for an ABI skew that moveit2's own deps no longer create. The range also blocks moveit_core from configuring on Ubuntu Resolute, which ships liboctomap-dev 1.10. Drop the range entirely. find_package(octomap REQUIRED) matches the convention used by fcl, Eigen3, pluginlib, and the rest of moveit_core. Refs: moveit#2862, moveit#2881.
55eba86 to
b65c2d1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3755 +/- ##
==========================================
+ Coverage 46.24% 46.25% +0.02%
==========================================
Files 726 726
Lines 59513 59512 -1
Branches 7623 7623
==========================================
+ Hits 27516 27522 +6
+ Misses 31831 31824 -7
Partials 166 166 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
1.9.7...<1.10.0version range onfind_package(octomap)inmoveit_core/CMakeLists.txtandmoveit_ros/occupancy_map_monitor/CMakeLists.txt. moveit2 already treats octomap like any other system dependency since PR #2881 switched both packages from<depend>octomap</depend>to<depend>liboctomap-dev</depend>— the version range was the leftover artifact of #2862's defensive workaround for an ABI skew that moveit2's own deps can no longer create.The narrow upper cap also blocks moveit_core from configuring on Ubuntu Resolute, which ships
liboctomap-dev 1.10.0+dfsg-3.A plain
find_package(octomap REQUIRED)matches the convention used byfcl,Eigen3,pluginlib, and every other system-installed dep inmoveit_core/CMakeLists.txt.Verification
Built
moveit_coreandmoveit_ros_occupancy_map_monitoragainst systemliboctomap-dev 1.10.0onubuntu:resoluteand against systemliboctomap-dev 1.9.7on a Noble container — both configure and build cleanly.Checklist