Skip to content

resolute: raise octomap version pin to allow 1.10#3755

Merged
nbbrooks merged 1 commit into
moveit:mainfrom
nbbrooks:nbbrooks/resolute-octomap-pin
Jun 16, 2026
Merged

resolute: raise octomap version pin to allow 1.10#3755
nbbrooks merged 1 commit into
moveit:mainfrom
nbbrooks:nbbrooks/resolute-octomap-pin

Conversation

@nbbrooks

@nbbrooks nbbrooks commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Drop the 1.9.7...<1.10.0 version range on find_package(octomap) in moveit_core/CMakeLists.txt and moveit_ros/occupancy_map_monitor/CMakeLists.txt. moveit2 already treats octomap like any other system dependency since PR #2881 switched both packages from <depend>octomap</depend> to <depend>liboctomap-dev</depend> — the version range was the leftover artifact of #2862's defensive workaround for an ABI skew that moveit2's own deps can no longer create.

The narrow upper cap also blocks moveit_core from configuring on Ubuntu Resolute, which ships liboctomap-dev 1.10.0+dfsg-3.

A plain find_package(octomap REQUIRED) matches the convention used by fcl, Eigen3, pluginlib, and every other system-installed dep in moveit_core/CMakeLists.txt.

Verification

Built moveit_core and moveit_ros_occupancy_map_monitor against system liboctomap-dev 1.10.0 on ubuntu:resolute and against system liboctomap-dev 1.9.7 on a Noble container — both configure and build cleanly.

Checklist

  • Required by CI: Code is auto formatted using clang-format (CMake only; cmake-format applied)
  • Extend the tutorials / documentation — N/A
  • Document API changes relevant to the user in the MIGRATION.md notes — N/A (build-system change)
  • Create tests, which fail without this PR — N/A
  • Include a screenshot if changing a GUI — N/A

@nbbrooks nbbrooks force-pushed the nbbrooks/resolute-octomap-pin branch from cc5fb89 to 55eba86 Compare June 16, 2026 04:50
moveit2 already treats octomap like any other system dependency since
PR moveit#2881 (which switched moveit_core / moveit_ros/occupancy_map_monitor
from <depend>octomap</depend> to <depend>liboctomap-dev</depend>). The
1.9.7...<1.10.0 range in CMakeLists.txt was the leftover artifact of
moveit#2862's defensive workaround for an ABI skew that
moveit2's own deps no longer create. The range also blocks moveit_core
from configuring on Ubuntu Resolute, which ships liboctomap-dev 1.10.

Drop the range entirely. find_package(octomap REQUIRED) matches the
convention used by fcl, Eigen3, pluginlib, and the rest of moveit_core.

Refs: moveit#2862, moveit#2881.
@nbbrooks nbbrooks force-pushed the nbbrooks/resolute-octomap-pin branch from 55eba86 to b65c2d1 Compare June 16, 2026 04:57
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.25%. Comparing base (e9471ff) to head (b65c2d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
+ Coverage   46.24%   46.25%   +0.02%     
==========================================
  Files         726      726              
  Lines       59513    59512       -1     
  Branches     7623     7623              
==========================================
+ Hits        27516    27522       +6     
+ Misses      31831    31824       -7     
  Partials      166      166              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nbbrooks nbbrooks merged commit b8eb06c into moveit:main Jun 16, 2026
10 of 13 checks passed
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant