Skip to content

Fix ERROR stream + check only active controllers for multiple chained controllers (backport #3556)#3766

Merged
nbbrooks merged 6 commits into
humblefrom
mergify/bp/humble/pr-3556
Jun 24, 2026
Merged

Fix ERROR stream + check only active controllers for multiple chained controllers (backport #3556)#3766
nbbrooks merged 6 commits into
humblefrom
mergify/bp/humble/pr-3556

Conversation

@mergify

@mergify mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Description

Hello Moveit Team,

When trying to control TIAGo Pro using moveit in Rviz I got this error:

[move_group-1] [ERROR] [1755075355.583941867] [moveit.plugins.ros_control_interface]: Controller with name %s chains to more than one controller. Chaining to more than one controller is not supported.
[move_group-1] [ERROR] [1755075355.584044598] [moveit_ros.trajectory_execution_manager]: Unable to identify any set of controllers that can actuate the specified joints: [ arm_left_1_joint arm_left_2_joint arm_left_3_joint arm_left_4_joint arm_left_5_joint arm_left_6_joint arm_left_7_joint ]
[move_group-1] [ERROR] [1755075355.584057241] [moveit_ros.trajectory_execution_manager]: Known controllers and their joints:
[move_group-1] 

This was due to a controller that is expected to be chained to several other controllers to be able to work, however this controller is not active when I did the test, it is just spawned by default in inactive

My change is to check chained controller only for active controllers and to fix the error message

Would this work or you prefer this to be fixed differently ?


This is an automatic backport of pull request #3556 done by Mergify.

… controllers (#3556)

(cherry picked from commit 848c062)

# Conflicts:
#	moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp
@mergify mergify Bot added the conflicts label Jun 23, 2026
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Author

Cherry-pick of 848c062 has failed:

On branch mergify/bp/humble/pr-3556
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 848c062a0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@nbbrooks nbbrooks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergify you are killing me

Comment thread moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp Outdated
Comment thread moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp Outdated
Comment thread moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp Outdated
Comment thread moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp Outdated
Co-authored-by: Nathan Brooks <nbbrooks@gmail.com>
Comment thread moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp Outdated
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.20%. Comparing base (e7004f4) to head (4a184ac).
⚠️ Report is 2 commits behind head on humble.

Files with missing lines Patch % Lines
...ontrol_interface/src/controller_manager_plugin.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3766      +/-   ##
==========================================
- Coverage   51.21%   51.20%   -0.00%     
==========================================
  Files         407      407              
  Lines       30667    30667              
==========================================
- Hits        15704    15701       -3     
- Misses      14963    14966       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nbbrooks and others added 3 commits June 23, 2026 17:49
Backport's getLogger replacement left the wrapped continuation lines at
the original main-branch indentation, but clang-format on humble wants
them at the alignment matching humble's RCLCPP_ERROR_STREAM column. No
behavioral change — just makes pre-commit's clang-format check pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@nbbrooks nbbrooks merged commit 2b2030d into humble Jun 24, 2026
7 checks passed
@nbbrooks nbbrooks deleted the mergify/bp/humble/pr-3556 branch June 24, 2026 01:01
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants