Fix ERROR stream + check only active controllers for multiple chained controllers (backport #3556)#3768
Open
mergify[bot] wants to merge 4 commits into
Open
Fix ERROR stream + check only active controllers for multiple chained controllers (backport #3556)#3768mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
Author
|
Tick the box to add this pull request to the merge queue (same as
|
nbbrooks
approved these changes
Jun 23, 2026
6 tasks
nbbrooks
added a commit
that referenced
this pull request
Jun 23, 2026
When the kilted branch was forked from main, two workflow files were overlooked and still target rolling/humble/jazzy: 1. .github/workflows/ci.yaml's matrix was testing kilted-branch code against rolling-ci/humble-ci/jazzy-ci images. PR CI thus failed for reasons unrelated to the PR (e.g. mergify-backported #3768 failed all 6 jobs because they ran on rolling+humble+jazzy infrastructure that doesn't match kilted's expected toolchain). 2. .github/workflows/docker.yaml's matrix kept ROS_DISTRO=[rolling], so the kilted branch never built its own moveit/moveit2:kilted-ci / kilted-release / kilted-source images. The push trigger also still pointed at branches: [main]. Match the jazzy branch's pattern: ci.yaml uses kilted-ci for both ccov and ikfast+clang-tidy jobs; docker.yaml builds kilted images and triggers on pushes to kilted. Followup work after this lands: - Trigger docker.yaml manually (workflow_dispatch on kilted) to build the first set of kilted-ci/release/source Docker images, OR push any commit to kilted to trigger automatically. - Once moveit/moveit2:kilted-ci exists, re-run CI on PR #3768 (and any other open kilted backports) so they have a real toolchain to test against. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kilted #3768 +/- ##
===========================================
+ Coverage 0.00% 46.22% +46.22%
===========================================
Files 120 720 +600
Lines 14611 59149 +44538
Branches 2106 7590 +5484
===========================================
+ Hits 0 27334 +27334
- Misses 14611 31648 +17037
- Partials 0 167 +167 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello Moveit Team,
When trying to control TIAGo Pro using moveit in Rviz I got this error:
This was due to a controller that is expected to be chained to several other controllers to be able to work, however this controller is not active when I did the test, it is just spawned by default in inactive
My change is to check chained controller only for active controllers and to fix the error message
Would this work or you prefer this to be fixed differently ?
This is an automatic backport of pull request #3556 done by Mergify.