Refactor/use prompt toolkit for optics config#319
Draft
kun-codes wants to merge 3 commits into
Draft
Conversation
added 3 commits
June 25, 2026 18:28
…tional` - removes the misleading `Optional[Config] = None` signature and the dead raise error line
Contributor
Author
|
This pr is not ready for merge yet. I have to test it more |
|
Member
|
it seems this migration even migrated the bugs in it. |
Contributor
Author
|
yes I will test it out. I never tested it so always kept it as a draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces use of
textualwithprompt_toolkit. The reason for usingprompt_toolkitis because the size of it and its dependencies are far lower than that oftextualI would be posting sizes later as the internet here is currently very slow.
Please merge this pr after merging #318