Fix ergonomics issues#339
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
besaleli
approved these changes
Mar 24, 2026
besaleli
left a comment
besaleli
left a comment
Member
There was a problem hiding this comment.
one tiny comment, this slays
| @@ -15,7 +15,8 @@ class EncoderfileBuilder: | |||
| config: str, | |||
| ) -> "EncoderfileBuilder": ... | |||
| @staticmethod | |||
| @@ -46,7 +47,8 @@ class TokenizerBuildConfig: | |||
| stride: Optional[int] | |||
|
|
|||
| @staticmethod | |||
| } | ||
| with pytest.raises(RuntimeError) as exc_info: | ||
| EncoderfileBuilder.from_dict(**config) | ||
| EncoderfileBuilder(**config) |
| prelude::*, | ||
| }; | ||
|
|
||
| #[pyclass(name = "Transform", frozen)] |
javiermtorres
force-pushed
the
javiermtorres/py-ergonomics
branch
from
March 24, 2026 15:15
0089bbc to
22f7734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides some ergonomics fixes in the Python bindings.
Closes #336
Closes #337
Closes #338