Skip to content

feat: Disambiguate version and runtime-version #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
besaleli merged 2 commits into from
Apr 24, 2026
Merged

feat: Disambiguate version and runtime-version #395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc57004
disambiguate runtime version
besaleli Apr 24, 2026
19bd9fc
update
besaleli Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions encoderfile/src/builder/cli/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ pub struct BuildArgs {
pub target: Option<TargetSpec>,
#[arg(
long,
help = "Encoderfile version override (defaults to current version)."
help = "Encoderfile base binary version override (defaults to current version)."
)]
pub version: Option<String>,
pub runtime_version: Option<String>,
#[arg(
long = "no-download",
help = "Disable downloading",
Expand Down Expand Up @@ -76,7 +76,7 @@ impl BuildArgs {
}

super::super::builder::EncoderfileBuilder::new(config)
.build(&self.version, self.no_download)
.build(&self.runtime_version, self.no_download)
}
}

Expand All @@ -90,7 +90,7 @@ pub fn test_build_args(
output_path: None,
base_binary_path: Some(base_binary_path.into()),
target: None,
version: None,
runtime_version: None,
no_download: true,
working_dir: None,
}
Expand All @@ -107,7 +107,7 @@ pub fn test_build_args_working_dir(
output_path: None,
base_binary_path: Some(base_binary_path.into()),
target: None,
version: None,
runtime_version: None,
no_download: true,
working_dir: Some(working_dir.into()),
}
Expand Down
Loading