Address Copilot review comments

- test_client: configure mock_page.__iter__.return_value instead of
  overwriting __iter__ with a lambda (more reliable mock iteration)
- examples: use documented env vars (GATEWAY_API_BASE / OTARI_AI_TOKEN)
  via OtariClient() auto-detection instead of OTARI_API_BASE /
  OTARI_PLATFORM_TOKEN, avoiding a KeyError when unset

Author: tbille

examples/quickstart.py

@@ -1,15 +1,16 @@
-"""Quick smoke test for the otari Python SDK (synchronous client)."""
+"""Quick smoke test for the otari Python SDK (synchronous client).
 
-import os
+Reads credentials from the SDK's documented environment variables:
+``GATEWAY_API_BASE`` (optional; defaults to the hosted gateway in platform
+mode) and ``OTARI_AI_TOKEN`` (or the legacy ``GATEWAY_PLATFORM_TOKEN``).
+"""
 
 from otari import OtariClient, OtariError
 
 
 def main() -> None:
-    client = OtariClient(
-        api_base=os.environ.get("OTARI_API_BASE", "http://localhost:8100"),
-        platform_token=os.environ["OTARI_PLATFORM_TOKEN"],
-    )
+    # Credentials are picked up from GATEWAY_API_BASE / OTARI_AI_TOKEN.
+    client = OtariClient()
 
     with client:
         # -- Chat completion --

examples/quickstart_async.py

@@ -1,16 +1,18 @@
-"""Quick smoke test for the otari Python SDK (asynchronous client)."""
+"""Quick smoke test for the otari Python SDK (asynchronous client).
+
+Reads credentials from the SDK's documented environment variables:
+``GATEWAY_API_BASE`` (optional; defaults to the hosted gateway in platform
+mode) and ``OTARI_AI_TOKEN`` (or the legacy ``GATEWAY_PLATFORM_TOKEN``).
+"""
 
 import asyncio
-import os
 
 from otari import AsyncOtariClient, OtariError
 
 
 async def main() -> None:
-    client = AsyncOtariClient(
-        api_base=os.environ.get("OTARI_API_BASE", "http://localhost:8100"),
-        platform_token=os.environ["OTARI_PLATFORM_TOKEN"],
-    )
+    # Credentials are picked up from GATEWAY_API_BASE / OTARI_AI_TOKEN.
+    client = AsyncOtariClient()
 
     async with client:
         # -- Chat completion --

tests/unit/test_client.py

@@ -442,7 +442,7 @@ def test_list_models_delegates(self, client: OtariClient) -> None:
         ]
 
         mock_page = MagicMock()
-        mock_page.__iter__ = lambda _self: iter(mock_models)
+        mock_page.__iter__.return_value = iter(mock_models)
         client.openai.models.list = MagicMock(return_value=mock_page)  # type: ignore[method-assign]
 
         result = client.list_models()