Skip to content

Commit 428a57e

Browse files
authored
Merge pull request #117 from skhamis/bump-version-21-2
Change strict_min_version to not include 0a1
2 parents dee1c81 + 092802d commit 428a57e

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,16 @@ The general process followed by the addons team is
4444
but at the current time, the maintainers of about-sync don't have the required
4545
permissions. Therefore, the process is:
4646

47-
* Consider bumping the version in `package.json` - that's not strictly necessary
48-
as the final version string will be something like `X.Y.Zbuildid20220601.073719`,
49-
but it makes it easier to work out what's in a version.
47+
* Bump the version in `package.json`
48+
> the final version string will be something like `X.Y.Zbuildid20220601.073719`
49+
50+
* If needed, bump the `strict_min_version` in `manifest.json`. Ensure there is a matching version you're targeting in the [version list](https://addons.mozilla.org/api/v5/applications/firefox/)
51+
> Must use an exact version, `{version_number}.*` are not allowed to be used
5052
5153
* Find the exact github revision revision you want as the new build; usually current `main`.
5254
Ensure this revision is tested using the [testing process described above](#testing-a-xpi)
5355

54-
* Join the #addons-pipeline slack channel, asking for a release to be built
55-
specifying that exact revision.
56+
* Follow the [Mozilla Add-on Review Request Intake](https://mozilla-hub.atlassian.net/wiki/spaces/FDPDT/pages/10617933/Mozilla+Add-on+Review+Requests+Intake) instructions to create an issue that will kick off the process for an update.
5657

5758
* You will be notified of an initial build, with will include a "dep-signing"
5859
task - however, this doesn't create the .xpi you can submit to AMO. Two

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"applications": {
1212
"gecko": {
1313
"id": "aboutsync@mhammond.github.com",
14-
"strict_min_version": "114.0a1"
14+
"strict_min_version": "114.0"
1515
}
1616
},
1717

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "aboutsync",
33
"private": true,
4-
"version": "0.21.1",
4+
"version": "0.21.2",
55
"description": "About Sync Firefox addon",
66
"scripts": {
77
"build": "webpack --mode=production && web-ext build",

0 commit comments

Comments
 (0)