added notification for removed page name

Author: Simpcyclassy

extension/background/intentRunner.js

@@ -6,10 +6,10 @@ import { metadata } from "../intents/metadata.js";
 import { compile, splitPhraseLines } from "../language/compiler.js";
 import { PhraseSet } from "../language/findMatch.js";
 import * as settings from "../settings.js";
+import { registerHandler, sendMessage } from "./communicate.js";
 import { entityTypes } from "./entityTypes.js";
 import * as intentParser from "./intentParser.js";
 import * as telemetry from "./telemetry.js";
-import { registerHandler, sendMessage } from "./communicate.js";
 
 const FEEDBACK_INTENT_TIME_LIMIT = 1000 * 60 * 60 * 24; // 24 hours
 // Only keep this many previous intents:
@@ -541,16 +541,18 @@ export async function getRegisteredPageName(name) {
   const result = await browser.storage.sync.get("pageNames");
   pageNames = result.pageNames;
 
+  return pageNames;
+}
+
+export async function unregisterPageName(name) {
+  pageNames = getRegisteredPageName(name);
   if (!pageNames[name] || !name) {
     const exc = new Error("No page name to remove");
     exc.displayMessage = `The page name "${name}" not found`;
     throw exc;
   }
-  return pageNames;
-}
-
-export async function unregisterPageName(name) {
   delete pageNames[name];
+
   log.info("Removed nickname for page", name);
   await browser.storage.sync.set({ pageNames });
 }

extension/intents/navigation/navigation.js

@@ -1,13 +1,13 @@
+import { sendMessage } from "../../background/communicate.js";
+import * as content from "../../background/content.js";
 import * as intentRunner from "../../background/intentRunner.js";
-import * as serviceList from "../../background/serviceList.js";
 import * as languages from "../../background/languages.js";
 import * as pageMetadata from "../../background/pageMetadata.js";
-import * as searching from "../../searching.js";
-import * as content from "../../background/content.js";
+import * as serviceList from "../../background/serviceList.js";
 import * as browserUtil from "../../browserUtil.js";
+import * as searching from "../../searching.js";
 import { metadata } from "../../services/metadata.js";
 import { performSearchPage } from "../search/search.js";
-import { sendMessage } from "../../background/communicate.js";
 
 const QUERY_DATABASE_EXPIRATION = 1000 * 60 * 60 * 24 * 30; // 30 days
 const queryDatabase = new Map();
@@ -35,8 +35,8 @@ intentRunner.registerIntent({
   name: "navigation.navigate",
   async run(context) {
     const query = context.slots.query.toLowerCase();
-    const result = await browser.storage.sync.get("pageNames");
-    const pageNames = result.pageNames;
+    const name = context.slots.name;
+    const pageNames = intentRunner.getRegisteredPageName(name);
     let tab = null;
     if (pageNames && pageNames[query]) {
       const savedUrl = pageNames[query];

extension/intents/nicknames/nicknames.js

@@ -110,7 +110,7 @@ intentRunner.registerIntent({
   name: "nicknames.removePageName",
   async run(context) {
     const name = context.slots.name;
-    await intentRunner.getRegisteredPageName(name);
     intentRunner.unregisterPageName(name);
+    context.presentMessage(`The page name ${name} has been removed`);
   },
 });