Skip to content
This repository was archived by the owner on Feb 26, 2021. It is now read-only.
This repository was archived by the owner on Feb 26, 2021. It is now read-only.

Routine matching is broken and too aggressive #1908

@ianb

Description

@ianb

To reproduce:

  • Create a routine named "test"
  • Try "this is a test" or "search for test" or anything with the word "test"

It shouldn't match at all, but it is also broken when it matches. The problematic code is here: https://github.com/mozilla-extensions/firefox-voice/blob/master/extension/background/intentRunner.js#L284-L305

I don't understand what handler.runRoutine is supposed to be about, and it actually breaks things. I think I was trying to be clever, but the cleverness was never used.

Maybe the entire logic needs to be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions