Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Commit 9ba608e

Browse files
Adding in aria-label for settings button. Fixes #370
1 parent 0e33780 commit 9ba608e

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/_locales/en_US/messages.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@
4040
"message": "Powered by Cloudflare®."
4141
},
4242
"popupToggleButton": {
43-
"message": "Firefox Private Network "
43+
"message": "Firefox Private Network"
44+
},
45+
"popupSettingsButtonLabel": {
46+
"message": "Settings"
4447
},
4548

4649
"toastProxyOff": {

src/view.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export class View {
7070

7171
static showSettings(shouldShow) {
7272
let settingsElement = document.getElementById("settingsButton");
73+
settingsElement.setAttribute("aria-label", currentView.getTranslation("popupSettingsButtonLabel"));
7374
settingsElement.toggleAttribute("hidden", !shouldShow);
7475
}
7576

0 commit comments

Comments
 (0)