Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Signed-off-by: Devota Aabel <14295757+devotaaabel@users.noreply.github.com>

Author: devotaaabel

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/pocket/controller/PocketStoriesController.kt

@@ -58,7 +58,7 @@ interface PocketStoriesController {
      * Callback to decide what should happen as an effect of a new list of stories being shown.
      *
      * @param storiesShown the new list of [PocketStory]es shown to the user.
-     * @param source the surface where the stories were shown.
+     * @param source The surface where the stories were shown.
      */
     fun handleStoriesShown(storiesShown: List<PocketStory>, source: StoriesImpressionSource)
 
@@ -75,7 +75,7 @@ interface PocketStoriesController {
      * @param storyClicked The just clicked [PocketStory].
      * @param storyPosition `row x column x index` matrix representing the grid and index position
      * of the clicked story.
-     * @param source the surface where the clicked story was shown.
+     * @param source The surface where the clicked story was shown.
      */
     fun handleStoryClicked(
         storyClicked: PocketStory,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/pocket/interactor/PocketStoriesInteractor.kt

@@ -27,7 +27,7 @@ interface PocketStoriesInteractor {
      * Callback for then new stories are shown to the user.
      *
      * @param storiesShown The new list of [PocketRecommendedStory]es shown to the user.
-     * @param source the surface where the stories were shown.
+     * @param source The surface where the stories were shown.
      */
     fun onStoriesShown(storiesShown: List<PocketStory>, source: StoriesImpressionSource)
 
@@ -44,7 +44,7 @@ interface PocketStoriesInteractor {
      * @param storyClicked The just clicked [PocketStory].
      * @param storyPosition `row x column x index` matrix representing the grid and index position
      * of the clicked story.
-     * @param source the surface where the clicked story was shown.
+     * @param source The surface where the clicked story was shown.
      */
     fun onStoryClicked(
         storyClicked: PocketStory,

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/middleware/HomeTelemetryMiddlewareTest.kt

@@ -56,7 +56,7 @@ class HomeTelemetryMiddlewareTest {
             assertEquals(recommendation.topic, extraValues["topic"])
             assertEquals(position.toString(), extraValues["position"])
             assertEquals("false", extraValues["is_sponsored"])
-            assertEquals("homepage", extraValues["source"])
+            assertEquals(StoriesImpressionSource.HOMEPAGE.sourceName, extraValues["source"])
 
             pingReceived = true
         }