Skip to content

Bug 2022578 - Fixed s2s bottomsheet not dismissing #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmasalha wants to merge 1 commit into from
+10 −0
Closed

Bug 2022578 - Fixed s2s bottomsheet not dismissing #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .../android/fenix/app/src/main/java/org/mozilla/fenix/summarization/SummarizationFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.fragment.app.viewModels
import androidx.compose.runtime.LaunchedEffect
import androidx.fragment.compose.content
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import androidx.navigation.fragment.navArgs
import com.google.android.material.bottomsheet.BottomSheetDialogFragment
import kotlinx.coroutines.suspendCancellableCoroutine
import mozilla.components.browser.state.selector.selectedTab
import mozilla.components.concept.engine.EngineSession
import mozilla.components.feature.summarize.SummarizationSettings
import mozilla.components.feature.summarize.SummarizationState
import mozilla.components.feature.summarize.SummarizationUi
import mozilla.components.feature.summarize.content.PageContentExtractor
import mozilla.components.feature.summarize.settings.SummarizeSettingsMiddleware
Expand Down Expand Up @@ -93,6 +96,13 @@ class SummarizationFragment : BottomSheetDialogFragment() {
),
)

val state = storeViewModel.store.stateFlow.collectAsStateWithLifecycle()
LaunchedEffect(state.value) {
if (state.value is SummarizationState.Finished) {
dismiss()
}
}

FirefoxTheme {
SummarizationUi(
productName = getString(R.string.app_name),
Expand Down
Loading