Bug 2023236 - Added error reporting to sentry for s2s errors#122
Closed
fmasalha wants to merge 1 commit into
Closed
Bug 2023236 - Added error reporting to sentry for s2s errors#122fmasalha wants to merge 1 commit into
fmasalha wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
fmasalha
commented
Mar 13, 2026
fmasalha
commented
Mar 13, 2026
| /** | ||
| * Interface for reporting a throwable. | ||
| */ | ||
| fun interface ErrorReporter { |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is a good or bad location for this to exist.
Contributor
There was a problem hiding this comment.
I would say it should go in its own file, either in the top level package feature/summarize or in a new error package feature/summarize/error
boek
suggested changes
Mar 17, 2026
Contributor
boek
left a comment
boek
left a comment
There was a problem hiding this comment.
This is close! just a couple of small tweaks and then its gtg
fmasalha
force-pushed
the
errorReportingS2S
branch
from
67bcd01 to
06760be
Compare
Contributor
Author
MatthewTighe
approved these changes
Mar 20, 2026
Contributor
MatthewTighe
left a comment
MatthewTighe
left a comment
There was a problem hiding this comment.
LGTM! Left a suggestion for your open question, but feel free to land after you've made a choice there.
| /** | ||
| * Interface for reporting a throwable. | ||
| */ | ||
| fun interface ErrorReporter { |
Contributor
There was a problem hiding this comment.
I would say it should go in its own file, either in the top level package feature/summarize or in a new error package feature/summarize/error
Contributor
Author
fmasalha
force-pushed
the
errorReportingS2S
branch
from
06760be to
68a2fc9
Compare
fmasalha
force-pushed
the
errorReportingS2S
branch
from
68a2fc9 to
e34a199
Compare
|
Pull request closed by commit ef93004 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
…ighe Pull request: #122
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 27, 2026
…ighe Pull request: mozilla-firefox/firefox#122 UltraBlame original commit: 272db71259cc983bf62571c974665bb103efe0fb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 27, 2026
…ighe Pull request: mozilla-firefox/firefox#122 UltraBlame original commit: 272db71259cc983bf62571c974665bb103efe0fb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 27, 2026
…ighe Pull request: mozilla-firefox/firefox#122 UltraBlame original commit: 272db71259cc983bf62571c974665bb103efe0fb
akliuxingyuan
pushed a commit
to akliuxingyuan/android-components
that referenced
this pull request
May 21, 2026
akliuxingyuan
pushed a commit
to fork-maintainers/iceraven-browser
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.