Bug 2024020 - Added an observability check on shakes in BrowserFrag#130
Closed
fmasalha wants to merge 1 commit into
Closed
Bug 2024020 - Added an observability check on shakes in BrowserFrag#130fmasalha wants to merge 1 commit into
fmasalha wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
fmasalha
commented
Mar 17, 2026
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun navigateToSummarizationIfEligible() { |
Contributor
Author
There was a problem hiding this comment.
linter said that the setup function was too complex after i added the gesture clause to I had to extract it.
Contributor
There was a problem hiding this comment.
I appreciate you fixing the linting issue!
fmasalha
commented
Mar 17, 2026
| // has not been recreated yet, we need to check if it's still active before proceeding. | ||
| val shakeEnabled = requireComponents.core.summarizeFeatureSettings.shakeToSummarizeEnabled | ||
|
|
||
| if (!shakeEnabled) { |
Contributor
Author
There was a problem hiding this comment.
According to the linter, 4 clauses is too much for an if statement to i placed this check alone at the top.
segunfamisa
approved these changes
Mar 18, 2026
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun navigateToSummarizationIfEligible() { |
Contributor
There was a problem hiding this comment.
I appreciate you fixing the linting issue!
Contributor
|
explanation for the "testing-exception-other" flag: the flow we are working with is hard to test with the way the browser fragment is set up. |
…it remains enabled
fmasalha
force-pushed
the
gestureListenFix
branch
from
c0ec6bd to
35bfb16
Compare
lando-worker Bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
…=segunfamisa Pull request: #130
|
Pull request closed by commit 627d374 |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 20, 2026
…=segunfamisa Pull request: mozilla-firefox/firefox#130 UltraBlame original commit: 2f826f93dd93e7132f27165c77d8a12da0d8fa0d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 20, 2026
…=segunfamisa Pull request: mozilla-firefox/firefox#130 UltraBlame original commit: 2f826f93dd93e7132f27165c77d8a12da0d8fa0d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 20, 2026
…=segunfamisa Pull request: mozilla-firefox/firefox#130 UltraBlame original commit: 2f826f93dd93e7132f27165c77d8a12da0d8fa0d
akliuxingyuan
pushed a commit
to fork-maintainers/iceraven-browser
that referenced
this pull request
Apr 23, 2026
…=segunfamisa Pull request: mozilla-firefox/firefox#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.