Bug 2006718 - Fix some typos in StartupExcessiveResourceUseTest#15
Closed
moztcampbell wants to merge 1 commit into
Closed
Bug 2006718 - Fix some typos in StartupExcessiveResourceUseTest#15moztcampbell wants to merge 1 commit into
moztcampbell wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
Contributor
Author
|
Try (triggered manually on Lando page) is here: https://treeherder.mozilla.org/jobs?revision=ee64f506f6b81ca838811e762a3c3a1c60369f7b&repo=try |
|
Pull request closed by commit 3d98859 |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2026
Pull request: mozilla-firefox/firefox#15 UltraBlame original commit: 350fb35b1d475e9fd2f9d63ad0ab5f0a839c57e4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2026
Pull request: mozilla-firefox/firefox#15 UltraBlame original commit: 350fb35b1d475e9fd2f9d63ad0ab5f0a839c57e4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2026
Pull request: mozilla-firefox/firefox#15 UltraBlame original commit: 350fb35b1d475e9fd2f9d63ad0ab5f0a839c57e4
akliuxingyuan
pushed a commit
to akliuxingyuan/firefox-android
that referenced
this pull request
Feb 25, 2026
runlevel5
added a commit
to runlevel5/firefox
that referenced
this pull request
May 11, 2026
…"lvx-only dest write" Twelve more probes building on the trunc_sat helper. Key results: mozilla-firefox#10 load-via-scratch loadUnalignedSimd128: 20/20 REPRO (no help) mozilla-firefox#15 compact single-write-to-dest SIMD: 10/10 REPRO at 30s mozilla-firefox#16 scalar body with correct lane mapping: 6/10 = 60% REPRO mozilla-firefox#17 sync;isync between two dest writes: 9/10 REPRO (no help) mozilla-firefox#18 single-instruction xvcvspsxws dest,src: 10/10 REPRO mozilla-firefox#19 3-insn body with 50 nops between dest writes: 8/10 REPRO mozilla-firefox#20 xvcvspsxws scratch + stxvd2x + lvx dest: 10/20 = 50% REPRO * mozilla-firefox#21 NaN-correct probe mozilla-firefox#20 (3 SIMD ops on scratch): 7/10 REPRO Probe mozilla-firefox#20 is the best partial fix. The KEY pattern: dest is written exactly once, via Altivec lvx from memory, with the trunc_sat result computed in scratch first. Adding more SIMD ops on scratch (probe mozilla-firefox#21) hurts even though the dest-write count is unchanged. NaN handling currently dropped (NaN -> INT32_MIN instead of NaN -> 0). Visually breaks lc.wasm rendering but does not affect the OOB rate measurement. Needs a wasm-correct re-derivation before landing. Residual 50% fires at DIFFERENT bytecode locations (29750, 105808) with the SAME captured vr5 = vperm-control byte pattern. Same root-cause corruption manifesting through other Ion SIMD paths. Helper-by-helper patching reduces but cannot eliminate -- the bug appears upstream of multiple lowered SIMD ops. Build verified clean, source committed for the ppc64 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.