Bug 2008772 - Remove unnecessary paddings that break the text field in "edit bookmarks" screen#18
Closed
segunfamisa wants to merge 1 commit into
Conversation
…it bookmarks" screen
segunfamisa
changed the title
Contributor
|
View this pull request in Lando to land it once approved. |
lando-worker Bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
…n "edit bookmarks" screen r=boek Pull request: #18
|
Pull request closed by commit f28145d |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 7, 2026
…n "edit bookmarks" screen r=boek Pull request: mozilla-firefox/firefox#18 UltraBlame original commit: 09dc32f05fcdac42e9f754655950fe5930ff0c77
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 7, 2026
…n "edit bookmarks" screen r=boek Pull request: mozilla-firefox/firefox#18 UltraBlame original commit: 09dc32f05fcdac42e9f754655950fe5930ff0c77
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 7, 2026
…n "edit bookmarks" screen r=boek Pull request: mozilla-firefox/firefox#18 UltraBlame original commit: 09dc32f05fcdac42e9f754655950fe5930ff0c77
akliuxingyuan
pushed a commit
to akliuxingyuan/firefox-android
that referenced
this pull request
Feb 25, 2026
…n "edit bookmarks" screen r=boek Pull request: mozilla-firefox/firefox#18
runlevel5
added a commit
to runlevel5/firefox
that referenced
this pull request
May 11, 2026
…"lvx-only dest write" Twelve more probes building on the trunc_sat helper. Key results: mozilla-firefox#10 load-via-scratch loadUnalignedSimd128: 20/20 REPRO (no help) mozilla-firefox#15 compact single-write-to-dest SIMD: 10/10 REPRO at 30s mozilla-firefox#16 scalar body with correct lane mapping: 6/10 = 60% REPRO mozilla-firefox#17 sync;isync between two dest writes: 9/10 REPRO (no help) mozilla-firefox#18 single-instruction xvcvspsxws dest,src: 10/10 REPRO mozilla-firefox#19 3-insn body with 50 nops between dest writes: 8/10 REPRO mozilla-firefox#20 xvcvspsxws scratch + stxvd2x + lvx dest: 10/20 = 50% REPRO * mozilla-firefox#21 NaN-correct probe mozilla-firefox#20 (3 SIMD ops on scratch): 7/10 REPRO Probe mozilla-firefox#20 is the best partial fix. The KEY pattern: dest is written exactly once, via Altivec lvx from memory, with the trunc_sat result computed in scratch first. Adding more SIMD ops on scratch (probe mozilla-firefox#21) hurts even though the dest-write count is unchanged. NaN handling currently dropped (NaN -> INT32_MIN instead of NaN -> 0). Visually breaks lc.wasm rendering but does not affect the OOB rate measurement. Needs a wasm-correct re-derivation before landing. Residual 50% fires at DIFFERENT bytecode locations (29750, 105808) with the SAME captured vr5 = vperm-control byte pattern. Same root-cause corruption manifesting through other Ion SIMD paths. Helper-by-helper patching reduces but cannot eliminate -- the bug appears upstream of multiple lowered SIMD ops. Build verified clean, source committed for the ppc64 branch.
feder-cr
added a commit
to feder-cr/invisible_firefox
that referenced
this pull request
May 21, 2026
…mWindow (issue mozilla-firefox#18) During iframe create/detach bursts (e.g. id.sky.com Grafana Faro session init), this observer can fire for a frame whose BrowsingContext is in mid-teardown. domWindow() returns undefined; unguarded this.domWindow().windowGlobalChild.innerWindowId threw TypeError, corrupting FrameTree state and propagating to "page disposed" — Playwright reported it as page.on('crash') though the content process was healthy. Guard: early-return when domWindow or windowGlobalChild is missing. The frame is gone anyway; nothing to register listeners on. Pre-fix: id.sky.com survived ~5 s. With this guard: ~17 s. The further disposal at +17 s is caused by missing BC FIELDs that live in the 38 PENDING upstream Playwright hunks (firefox-7 work). Issue: feder-cr/invisible_playwright#18 Doc reference: docs/firefox-stealth-architecture/70-known-bugs.md
feder-cr
added a commit
to feder-cr/invisible_firefox
that referenced
this pull request
May 21, 2026
10 files from microsoft/playwright/browser_patches/firefox/patches/bootstrap.diff. Applied cleanly. Adds: - LoadInfo: `jugglerLoadIdentifier` attribute (correlates network requests across BC tree) - TRRLoadInfo: stub for jugglerLoadIdentifier in DNS-over-HTTPS context - nsINetworkInterceptController: `interceptAfterServiceWorkerResets()` method on nsIInterceptedChannel - DocumentLoadListener: propagate jugglerLoadIdentifier parent → content - InterceptedHttpChannel: C++ impl of interceptAfterServiceWorkerResets + flag mInterceptAfterServiceWorkerResets - nsHttpChannel: IsForcedOffline stubbed to `return false` because the required BC.ForceOffline FIELD is in the 38 PENDING upstream hunks we haven't ported yet (firefox-7 work) Without these, Juggler's NetworkObserver.js calls C++ methods that don't exist, throws TypeError, leaves C++ NetworkObserver in inconsistent state, eventually crashes content process on the next channel touch. That was the C++ side of issue mozilla-firefox#18. Pairs with the JS-side guard in juggler/content/FrameTree.js (separate commit). Doc reference: docs/firefox-stealth-architecture/20-our-patches.md §19, 30-upstream-playwright-patches.md (netwerk/ row marked APPLIED).
feder-cr
added a commit
to feder-cr/invisible_firefox
that referenced
this pull request
May 22, 2026
…rface to writable output buffer (issue mozilla-firefox#18 teardown crash) The stealth seed-derived pixel noise was being applied to rawData.mData which is mapped read-only (DataSourceSurface::READ at line 6765). Writing to a read-only mapped surface is undefined behavior — on CPU-backed canvases the memory is writable in practice, but on GPU- backed canvases (which Windows alt-desktop forces id.sky.com into via the security.sandbox.gpu.level=0 + CreateDesktop combination) the backing memory is write-protected. A write attempt segfaults. Symptom: page.on('crash') fires at browser.close() when running on Windows alt-desktop (headless=True in InvisiblePlaywright) against id.sky.com or any page that triggers a final getImageData during unload. Bisected to this single site by disabling all 14 fpp-hw-seed spoof code paths one group at a time. Fix: move the noise application to AFTER the SwizzleData/UnpremultiplyData step, operating on the JS Uint8ClampedArray's backing buffer (`data`) which is always writable. Functionally equivalent — callers consume the JS array, not the source surface. Reference: wrapper repo issue mozilla-firefox#18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.